Skip to content

Add patch skipping TestMachoIssue32233 #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagood merged 1 commit into from
Mar 20, 2026
+26 −0
Merged

Add patch skipping TestMachoIssue32233 #2202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions patches/0015-Skip-consistently-failing-TestMachoIssue32233.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: bot-for-go[bot] <199222863+bot-for-go[bot]@users.noreply.github.com>
Date: Fri, 20 Mar 2026 08:55:22 -0700
Subject: [PATCH] Skip consistently failing TestMachoIssue32233

Skip TestMachoIssue32233, which recently has often (?) failed PR validation and
blocks unrelated changes. We don't expect the behavior of this test to be
changed by our patches.

Tracked at https://github.com/microsoft/go/issues/2200
---
src/cmd/link/internal/ld/dwarf_test.go | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/cmd/link/internal/ld/dwarf_test.go b/src/cmd/link/internal/ld/dwarf_test.go
index 3cede8fe4b99a1..0c4b75f8456cb7 100644
--- a/src/cmd/link/internal/ld/dwarf_test.go
+++ b/src/cmd/link/internal/ld/dwarf_test.go
@@ -1203,6 +1203,7 @@ func TestPackageNameAttr(t *testing.T) {
}

func TestMachoIssue32233(t *testing.T) {
+ t.Skip("failing, may be flaky: https://github.com/microsoft/go/issues/2200")
testenv.MustHaveGoBuild(t)
testenv.MustHaveCGO(t)

Loading