feat(project-planning): ISA-95 network planner agent#1177
feat(project-planning): ISA-95 network planner agent#1177
Conversation
…ections 🔒 - Generated by Copilot
🔒 - Generated by Copilot
…t requirements and visual walkthrough - add markdown assessment file creation guidelines - specify output paths and content structure - include visual walkthrough requirements with Mermaid diagram - improve clarity for non-experts with plain-language explanations 🔒 - Generated by Copilot
…d assumption handling - add comprehensive intake question script for missing fields - implement low-confidence assumption mode for unanswered items - establish intake-gate-pending structure for incomplete intake - clarify output requirements based on intake completeness 🔒 - Generated by Copilot
…5 Planner - update references in collections and README files - remove old agent file and create new one with updated name - ensure consistency across documentation and plugin files 🔄 - Generated by Copilot
…ents documentation 🔒 - Generated by Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1177 +/- ##
==========================================
- Coverage 87.66% 87.65% -0.02%
==========================================
Files 61 61
Lines 9328 9328
==========================================
- Hits 8177 8176 -1
- Misses 1151 1152 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Dependency Review SummaryThe full dependency review summary was too large to display here (3099KB, limit is 1024KB). Please download the artifact named "dependency-review-summary" to view the complete report. |
|
Thanks for your proposal of the new agent. One thing I would like to raise here is a discussion on whether this agent makes much sense into the hve-core 'Project Planning' collection, or any of the existing collections for that matter. This agent is very domain-specific, while all other agents in the collection are intentionally agnostic. My first reflection was whether this makes more sense in Thoughts? |
Bill and I briefly discussed where to put this as it could live in edge-ai or here. I decided to put it here as the intent is to be more general. The first pass is very edge-ai as it's what I used to build the agent off of. As we get more clarity on how this agent is used and how it evolves, we can always move it later. |
bindsi
left a comment
There was a problem hiding this comment.
I really like this agent´s clear structure and purpose to cover a difficult and very important domain for customers.
But I suggest to query more information in the intake process for the brownfield or greenfield scenarios. On the one hand for brownfield it might be relavent to reuse own (reverse) proxies, gateways, vpn, etc. and on the other hand for greenfield the target architecture might be relevant --> maybe be pointing to some Microsoft recommendations (like for AIO https://learn.microsoft.com/en-us/azure/iot-operations/manage-layered-network/concept-iot-operations-in-layered-network, https://github.com/Azure-Samples/explore-iot-operations/blob/main/samples/layered-networking/aio-layered-network.md), maybe we can also address them as a skill and reference those here in the agent.
Could also do what we did for the security planner and reference the WAF and CAF to fold in those default Azure Practices |
…kills - introduce ISA-95-aligned network planning assistant for secure edge Kubernetes to Azure connectivity - add runtime lookup guidance for ISA-95 network planning across Azure IoT Operations layered networking, WAF, and CAF - update collections to include new skills and agents 🔒 - Generated by Copilot
…d Network Azure Guidance skills 🔗 - Generated by Copilot
|
I added more intake questions for both greenfield and brownfield scenarios. Moved the .md into its own networking folder since I do see it get more expansive in the future. Also added a skills .md to follow security, to help provide those default practices |
| - Researcher Subagent | ||
| handoffs: | ||
| - label: "🛡️ Security Plan" | ||
| agent: Security Plan Creator |
There was a problem hiding this comment.
Does this refer to security-planner.agent.md? If so, the agent-name needs a slight correction.
| agent: Security Plan Creator | |
| agent: Security Planner |
katriendg
left a comment
There was a problem hiding this comment.
Thanks for this new agent. I've left a few comments, I think the agent is a good groundwork, just wondering if it is at the right location (collection), and if the skill adds much value. If we can simplify without it, I would choose that option.
| @@ -0,0 +1,77 @@ | |||
| --- | |||
There was a problem hiding this comment.
Is there a reason why this works well as a skill? Does it get progressively loaded, it's just a single file so I wonder if it has value as a skill. Is it intended as a prompt /network-azure-guidance call? I'm trying to understand how it will be called and if a prompt file makes as much sense?
The agent already has similar delegation, maybe we can just keep the agent?
| @@ -0,0 +1,77 @@ | |||
| --- | |||
There was a problem hiding this comment.
The folder name of this skill must match the name of the collection in which you put it. Looking at the location, this folder should be project-planning and not shared.
| @@ -0,0 +1,393 @@ | |||
| --- | |||
There was a problem hiding this comment.
The folder name should match the collection, all agents for a collection should be in the same folder. I believe this one should be agents/project-planning/...
| agents: | ||
| - Researcher Subagent | ||
| handoffs: | ||
| - label: "🛡️ Security Plan" |
There was a problem hiding this comment.
Security Planner agent is part of another collection and should typically not be made available as a handoff. If the user installs the Project Planning collection this button will fail. Only calls to hve-core (flagship) agents are typically allowed. Maybe the question is whether this network ISA95 agent should be moved to security collection instead? Then it would be OK to call a sibling agent.
| - path: .github/agents/project-planning/brd-builder.agent.md | ||
| kind: agent | ||
| - path: .github/agents/network/network-isa95-planner.agent.md | ||
| kind: agent |
There was a problem hiding this comment.
We recommend making the initial version of the agent available only with maturity: experimental so it gets released in Pre-Release and not yet to Stable. Same for the skill.
Pull Request
Description
Created the ISA-95 network planning agent and updated collection references to the new path.
This PR also refreshed plugin linkage so the agent remains discoverable in bundled outputs.
Related Issue(s)
None
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
Execution Flow:
Output Artifacts:
.copilot-tracking/reviews/{{YYYY-MM-DD}}-network-isa95-assessment.md(default path when caller does not provide one)Preview: