Open
Conversation
WilliamBerryiii
requested changes
Apr 3, 2026
Member
WilliamBerryiii
left a comment
There was a problem hiding this comment.
Thank you for this PR, @bjcmit. The eval-dataset-creator agent is a solid addition to the data-science collection — the structured interview flow and dual-persona support are well thought out.
After review, there are a few suggested changes in the inline comments. Please take a look and let us know if you have any questions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
- Coverage 87.66% 87.65% -0.02%
==========================================
Files 61 61
Lines 9328 9328
==========================================
- Hits 8177 8176 -1
- Misses 1151 1152 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
WilliamBerryiii
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a comprehensive new prompt,
eval-dataset-creator.md, for generating evaluation datasets and documentation to support AI agent testing. The prompt guides users through a structured interview process to curate Q&A pairs, select evaluation metrics, and recommend tooling tailored to user skill level and agent characteristics. It also specifies the output directory structure and includes templates for all generated artifacts.Key additions and improvements:
Evaluation Dataset Creation Workflow:
Dataset and Documentation Artifacts:
data/evaluation/with separate subfolders for datasets (.json,.csv) and documentation (curation-notes.md,metric-selection.md,tool-recommendations.md).Tooling and Persona Guidance:
Related Issue(s)
Closes #1267
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/agents/*.agent.md)Sample Prompts (for AI Artifact Contributions)
User Request:
Execution Flow:
Here’s a step-by-step breakdown of what happens when the Evaluation Dataset Creator agent is invoked, including tool usage and key decision points:
Purpose: Gather all necessary context before generating any artifacts.
Phase 1: Agent Context**
Phase 2: Agent Capabilities
Phase 3: Evaluation Scenarios
Phase 4: Persona & Tooling
data/evaluation/datasets/.data/evaluation/docs/:data/evaluation/docs/.Decision Points & Tool Usage Summary
Output Artifacts:
data/evaluation/datasets/-eval-dataset.json
{ "metadata": { "schema_version": "1", "agent_name": "example-agent", "created_date": "2026-04-02", "version": "1.0.0", "total_pairs": 30, "distribution": { "easy": 6, "grounding_source_checks": 3, "hard": 12, "negative": 6, "safety": 3 }, "persona": "pro-code", "evaluation_mode": ["manual", "batch"], "recommended_tool": "azure-ai-foundry" }, "evaluation_pairs": [ {data/evaluation/docs/-curation-notes.md
data/evaluation/docs/-metric-selection.md
data/evaluation/docs/-tool-recommendations.md
Success Indicators:
Testing
/prompt-analyze3 times with all findings addressednpm run lint:all✅npm run lint:md-links✅npm run validate:copyright✅ (148/148 files, 100%)npm run spell-check✅ (281 files, 0 issues)npm run plugin:generate✅ (14 plugins, 0 errors)npm run plugin:validate✅ (0 errors)npm run lint:collections-metadata✅ (0 errors)Checklist
Required Checks
AI Artifact Contributions
/prompt-analyzeto review contributionprompt-builderreviewRequired Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generateSecurity Considerations