[Windows] Search for the closest free page for allocate jit memory in x64#122
Open
lucianopa-msft wants to merge 1 commit intomicrosoft:mainfrom
Open
[Windows] Search for the closest free page for allocate jit memory in x64#122lucianopa-msft wants to merge 1 commit intomicrosoft:mainfrom
lucianopa-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Collaborator
|
Hi @lucianopa-msft , thanks for providing the fix! Would you mind adding some tests to cover the change. Ideally, those tests should fail on main branch but pass with your changes. Thanks! |
Member
Author
|
I really tried to but couldn't get a repro testing repro that mimics the exact crash. So there may be special conditions for the repro I am still not sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous algorithm would take the base address compute 2GB up and start searching for a free page there (starting from furtherst from base address). Depending on the base address this could cause
VirtualAllocto try access an invalid memory range (stack memory) causing a crash. This changes the implementation to look instead for the closest free page.This also makes it consistent with other implementations such as
allocate_jit_memory_unix