fix(spelling): allow _wcsnicmp CRT function name#184
Merged
Conversation
The check-spelling workflow strips the leading underscore from _wcsnicmp (used in src/cascadia/inc/WtaProcess.h) and flagged 'wcsnicmp' as unknown. It's a stable Windows CRT wide-string compare function, so add it to allow/apis.txt next to its sibling wcsnlen. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds wcsnicmp to the spell-check allow list so the check-spelling workflow stops flagging the _wcsnicmp CRT call in src/cascadia/inc/WtaProcess.h (the leading underscore is stripped before lookup).
Changes:
- Insert
wcsnicmpalphabetically inapis.txt, adjacent to its siblingwcsnlen.
This comment has been minimized.
This comment has been minimized.
These 4 case-variants in expect.txt are unused in the codebase — only their differently-cased counterparts in allow/ are needed: PSobject (lowercase 'psobject' kept in allow/allow.txt) Signtool (lowercase 'signtool' kept in allow/allow.txt) VTE (lowercase 'vte' kept in allow/allow.txt) WTCLI (lowercase 'wtcli' kept in allow/apis.txt) NOTE: check-spelling is case-sensitive, so ftcs/msaa/stdcpp (lowercase forms used in markdown image filenames, C++ local variables, and the stdcpp20/stdcpp17 MSBuild property) are kept — even though uppercase FTCS/MSAA/STDCPP exist in allow/. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
yeelam-gordon
force-pushed
the
dev/yeelam/fix-spelling-wcsnicmp
branch
from
2f26cf9 to
61eb038
Compare
vanzue
approved these changes
Jun 2, 2026
DDKinger
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small check-spelling config cleanups, both pre-existing (not from #182):
1. Allow the
_wcsnicmpCRT function nameThe workflow strips the leading underscore from
_wcsnicmp(used insrc/cascadia/inc/WtaProcess.h) and flaggedwcsnicmpas unrecognized. Added it toallow/apis.txtnext to its siblingwcsnlen.2. Remove 4 unused case-variant duplicates from
expect/expect.txtcheck-spelling is case-sensitive, so allow/ entries only cover the exact casing listed. These 4 expect.txt entries have differently-cased counterparts in allow/ AND aren't used in the codebase, so they're dead weight:
PSobjectallow/allow.txtpsobjectSigntoolallow/allow.txtsigntoolVTEallow/allow.txtvteWTCLIallow/apis.txtwtcliNOT removed (lowercase forms appear in code, so allow/ uppercase doesn't cover):
ftcs→doc/specs/#11000 - Marks/Shell-Integration-Marks.md(image filename)msaa→src/host/AccessibilityNotifier.cpp(C++ local variable)stdcpp→src/common.build.pre.props(MSBuildstdcpp20/stdcpp17)