Skip to content

Fallback to COM1 port on azure#787

Open
praveen-pk wants to merge 1 commit intomicrosoft:mainfrom
praveen-pk:azure/serial_port
Open

Fallback to COM1 port on azure#787
praveen-pk wants to merge 1 commit intomicrosoft:mainfrom
praveen-pk:azure/serial_port

Conversation

@praveen-pk
Copy link
Copy Markdown

Azure VMs do not support COM2 port. If built with azure feature use COM1 as the serial port.

Copy link
Copy Markdown
Contributor

@sangho2 sangho2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

I have no preference, but we might want to decide the default configuration: Azure Hyper-V (COM1) or Windows Hyper-V (COM2). @tgopinath-microsoft ?

@praveen-pk
Copy link
Copy Markdown
Author

Make sense. As Azure will be the most used target, I am inclined to make Azure the default and Hyper-V a build time config.

Azure VMs do not support COM2 port. So set the default to COM1 port.
Introduced devbox build time feature, if enabled with `--devbox`, COM2
will be used by LitBox.

Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Copy link
Copy Markdown
Contributor

@tgopinath-microsoft tgopinath-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discussed with Praveen and COM1 (port of Azure VMs) are now the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants