Open
Conversation
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
Comment on lines
+483
to
+487
| // In debug builds, log violations instead of silently returning an error so that | ||
| // it won't fail silently during development (which may hard to debug) and we can | ||
| // tell there are missing seccomp rules to be added by comparing debug and release runs. | ||
| if cfg!(debug_assertions) { | ||
| SeccompAction::Log |
Member
There was a problem hiding this comment.
Minor suggestion: we can use SCMP_ACT_TRAP to get a SIGSYS with SYS_SECCOMP that we can use to actually log via litebox_util_log::error!(...) which might be nicer than needing to diff debug/release runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #793 to enable seccomp filter for Linux userland.
In debug mode, disallowed syscalls would be only logged but proceed normally. This may help make development easier because some syscalls are implicitly called by libc function and thus it might not be obvious to figure out we miss some seccomp rules. We can still tell there are missing seccomp rules by comparing debug and release runs.