Open
Conversation
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sangho2 found out a subtle issue in
RwLockwith help of GPT-5.5.Agent implemented a test to reproduce the issue (see
test_rwlock_readers_not_starved_after_writer_handoff) and the scenario for the bug is the following:On Windows
wake_onealways returnstrueeven though no writer is blocked (because Windows does not tell how may waiters were woken up and our previous implementation just returns the number of waiters requested), so it returns early without waking readers. Readers are stuck forever.Looking at how std handles Windows, it turns out it always return
false(meaning no waiters were woken up). This fix just follows that.