Skip to content

Start a host when calling commands via CLI to capture telemetry#2124

Draft
alzimmermsft wants to merge 1 commit intomicrosoft:mainfrom
alzimmermsft:StartHostToCaptureTelemetry
Draft

Start a host when calling commands via CLI to capture telemetry#2124
alzimmermsft wants to merge 1 commit intomicrosoft:mainfrom
alzimmermsft:StartHostToCaptureTelemetry

Conversation

@alzimmermsft
Copy link
Contributor

What does this PR do?

When processing a call to the MCP server executable directly the following is performed (rather than just accepting the command to call from the manually managed ServiceCollection):

Bind the manually maintained ServiceCollection with just the commands to start the MCP server. If the command is found invoke it as-is, as it will handle everything else for us. If the command isn't found, assume this is a direct tool call, rather than process start, bind everything up as if we're running in STDIO mode and run the command, capturing a CommandExecuted telemetry event.

GitHub issue number?

[Link to the GitHub issue this PR addresses]

Pre-merge Checklist

  • Required for All PRs
    • Read contribution guidelines
    • PR title clearly describes the change
    • Commit history is clean with descriptive messages (cleanup guide)
    • Added comprehensive tests for new/modified functionality
    • Created a changelog entry if the change falls among the following: new feature, bug fix, UI/UX update, breaking change, or updated dependencies. Follow the changelog entry guide
  • For MCP tool changes:
    • One tool per PR: This PR adds or modifies only one MCP tool for faster review cycles
    • Updated servers/Azure.Mcp.Server/README.md and/or servers/Fabric.Mcp.Server/README.md documentation
    • Validate README.md changes running the script ./eng/scripts/Process-PackageReadMe.ps1. See Package README
    • For new or modified tool descriptions, ran ToolDescriptionEvaluator and obtained a score of 0.4 or more and a top 3 ranking for all related test prompts
    • For tools with new names, including new tools or renamed tools, update consolidated-tools.json
    • For renamed tools, follow the Tool Rename Checklist and tag the PR with the breaking-change label
    • For new tools associated with Azure services or publicly available tools/APIs/products, add URL to documentation in the PR description
  • Extra steps for Azure MCP Server tool changes:
    • Updated command list in servers/Azure.Mcp.Server/docs/azmcp-commands.md
    • Ran ./eng/scripts/Update-AzCommandsMetadata.ps1 to update tool metadata in azmcp-commands.md (required for CI)
    • Updated test prompts in servers/Azure.Mcp.Server/docs/e2eTestPrompts.md
    • 👉 For Community (non-Microsoft team member) PRs:
      • Security review: Reviewed code for security vulnerabilities, malicious code, or suspicious activities before running tests (crypto mining, spam, data exfiltration, etc.)
      • Manual tests run: added comment /azp run mcp - pullrequest - live to run Live Test Pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

1 participant