Restore MUXControls GitHub validation - #11179
Open
harshit7962 wants to merge 10 commits into
Open
Conversation
microsoft-github-policy-service
Bot
added
the
needs-triage
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Contributor
Author
|
/AzurePipelines run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
harshit7962
force-pushed
the
user/hmishra/gh-pr-ado-muxcontrols-restore
branch
from
June 23, 2026 06:49
61e0b69 to
c0550e1
Compare
harshit7962
changed the title
codendone
requested changes
Jun 24, 2026
codendone
left a comment
codendone
left a comment
Contributor
There was a problem hiding this comment.
The PR description suggests this might be needed because of WinUI Gallery issues. The Gallery issue may have been addressed via: Commit f3b1c5d. Does that change remove the need for this PR or reduce what needs to be changed?
| type: git | ||
| name: WinUI/microsoft-ui-xaml-lift | ||
| ref: refs/heads/main | ||
| ref: refs/heads/user/hmishra/gh-ado-muxcontrols-restore-clean |
Contributor
There was a problem hiding this comment.
Presumably this needs to be reverted before completing.
| pgoBuildModeMSBuildArg: '/p:PGOBuildMode=Off' | ||
| buildProductOnly: true | ||
| buildMuxControlsSln: true | ||
| muxControlsAdditionalMSBuildOptions: '/p:IsInternalWinUIBuild=false /p:PublishTrimmed=false /p:EnableTrimAnalyzer=false /p:EnableAotAnalyzer=false /p:IsAotCompatible=false' |
Contributor
There was a problem hiding this comment.
Why all of these msbuild options? Do internal builds specify these? If not, why do OSS builds need them?
Use the normal non-product GitHub validation build path so MUXControls.sln runs without a dedicated MUXControls-only switch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
harshit7962
force-pushed
the
user/hmishra/gh-pr-ado-muxcontrols-restore
branch
from
July 1, 2026 13:09
d3a2652 to
339a622
Compare
Point the GitHub validation wrapper back to ADO main while keeping the normal non-product build path enabled for MUXControls.sln validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Point the GitHub validation wrapper at the ADO branch that applies OSS package pins for GitHub-backed builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Pass IsInternalWinUIBuild=false into the GitHub validation build so MUXControls.sln restore uses pinned OSS package versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use a separate WinUIPackageVersion for PackageReference resolution so GitHub-backed MUXControls validation restores an OSS-safe Microsoft.WindowsAppSDK.WinUI package while preserving the build WinUIVersion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use WinUIPackageVersion for direct Microsoft.WindowsAppSDK.WinUI package imports so GitHub-backed MUXControls validation restores the same pinned package used by PackageReference. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
harshit7962
force-pushed
the
user/hmishra/gh-pr-ado-muxcontrols-restore
branch
5 times, most recently
from
July 3, 2026 09:04
2e68985 to
7923f3f
Compare
Add explicit PackageReference entries for projects that directly import Microsoft.WindowsAppSDK.WinUI package props/targets so restore downloads the pinned WinUIPackageVersion. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
harshit7962
force-pushed
the
user/hmishra/gh-pr-ado-muxcontrols-restore
branch
from
July 3, 2026 10:44
7923f3f to
2b35e00
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
N/A
PR Type
Description
Current Behavior
GitHub-backed PR validation runs the reduced product-only ADO build path. That keeps the GitHub validation graph safe, but it does not run
MUXControls.sln.MUXControls.Test.csprojalso assumes WinUI Gallery test data exists in the checkout, which is not guaranteed in the public GitHub validation context.New Behavior
The GitHub PR wrapper opts into the ADO template's
buildMuxControlsSlnpath soMUXControls.slnis validated while the rest of the GitHub validation graph remains reduced-scope.MUXControls.Test.csprojnow generates WinUI Gallery test data only when the Gallery data file is present, allowing the project to build from the GitHub checkout.Note: this branch currently points
WinUIInternal.refto the matching template branch for validation. Before merging, switch it back torefs/heads/main.Customer Impact
No direct product/customer-facing impact. This restores CI coverage for MUXControls changes in GitHub-backed PR validation.
Regression Potential
The wrapper change only affects GitHub PR validation. The missing Gallery data guard only skips generated test data when the input file is absent.
How Has This Been Tested?
I have performed a self-review of my own code
I have added tests to cover my changes
Existing tests pass locally
GitHub PR validation succeeded against the matching template branch.
Screenshots (if appropriate)
N/A