Add AI-assisted contribution guidance and strengthen verification expectations - #11190
Draft
niels9001 wants to merge 2 commits into
Draft
Add AI-assisted contribution guidance and strengthen verification expectations#11190niels9001 wants to merge 2 commits into
niels9001 wants to merge 2 commits into
Conversation
…ectations Adds an explicit policy for AI/agent-assisted contributions, modeled on the TypeScript and typescript-go repos, and reinforces author verification of changes. - CONTRIBUTING.md: new 'Use of AI assistance' section (disclosure requirement, bulk/agent-driven PR ban, instructions for autonomous agents) plus a 'Verify your own changes' subsection covering repro steps and screenshots/recordings. Rename heading to 'Contributing to WinUI'. - PULL_REQUEST_TEMPLATE.md: add AI disclosure checkboxes, a verification/repro steps field, a 'verified the new behavior myself' checkbox, and a Screenshots / Screen recording section. - AGENTS.md: new root file orienting coding agents to contribution rules, manual verification expectations, build/test skills, and PR requirements. - Remove orphaned root CONTRIBUTION_HANDLING.md (canonical copy lives at docs/external/contribution_handling.md). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment-triggered workflow: a maintainer commenting /needs-verification on an issue or PR posts a templated request asking the author to manually verify their change (linking to the 'Verify your own changes' section of CONTRIBUTING.md) and applies the existing needs-author-feedback label, which plugs into the repo's stale-bot automation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
N/A - documentation/process improvement, no tracking issue.
PR Type
Description
WinUI's contributor docs had no guidance for AI/agent-assisted contributions, which are increasingly common and, when unmanaged, flood maintainers with low-context or duplicate PRs. Other major Microsoft repos (notably
microsoft/TypeScriptandmicrosoft/typescript-go) have addressed this with explicit policies; WinUI had a gap. This PR closes that gap, reinforces that authors must verify their own changes, and adds a maintainer command to request that verification.Current Behavior
AGENTS.mdto orient coding agents to the repo's contribution rules.CONTRIBUTION_HANDLING.mdat the root (orphaned, nothing links to it) and the canonicaldocs/external/contribution_handling.mdthatCONTRIBUTING.mdandREADME.mdlink to.New Behavior
CONTRIBUTING.md: new "Use of AI assistance" section (AI tools are welcome, disclosure is required, bulk/agent-driven PRs are not accepted, plus an "Instructions for autonomous coding agents" subsection). New "Verify your own changes" subsection requiring repro/verification steps and a screenshot or short screen recording for user-visible changes. Heading renamed to "Contributing to WinUI"..github/PULL_REQUEST_TEMPLATE.md: adds AI disclosure checkboxes, a verification / repro steps field, a "ran and verified the new behavior myself" checkbox, and a "Screenshots / Screen recording" section.AGENTS.md: agent-facing orientation covering PR acceptance rules, the proposal gate for public API/UI, manual verification expectations, build/test skills, and PR requirements..github/workflows/needs-verification-command.yml: a maintainer can comment/needs-verificationon an issue or PR to post a templated request asking the author to manually verify their change (linking to the "Verify your own changes" section) and apply the existingneeds-author-feedbacklabel, which plugs into the repo's stale-bot automation. The message is intentionally neutral and does not call out AI.CONTRIBUTION_HANDLING.md; the canonical copy atdocs/external/contribution_handling.mdremains.The AI policy language is adapted from the TypeScript repos but tailored to WinUI's process (2 approvals, CLA, feature-proposal gate, squash merge).
Customer Impact
Contributor-facing process/docs plus one maintainer-only automation. No product or runtime code changes. Sets clearer expectations for community contributors and reduces maintainer triage burden.
Regression Potential
Docs/templates plus a new comment-triggered workflow that is gated to maintainers (OWNER/MEMBER/COLLABORATOR) and reuses an existing label. Verified internal links resolve, no remaining references point to the removed file, and the workflow YAML parses.
How Has This Been Tested?
Verification / repro steps:
grepfinds no remaining references toCONTRIBUTION_HANDLING.md;CONTRIBUTING.mdandREADME.mdstill link todocs/external/contribution_handling.md.needs-verification-command.ymlparses as YAML and gates on the command + maintainer association; it reuses theneeds-author-feedbacklabel already used by.github/policies/resourceManagement.yml.AI Assistance
Screenshots / Screen recording
N/A - text and workflow change.