Restore WinUIGallery build validation - #11350
Open
gpaskaleva-msft wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
added
the
needs-triage
Author
|
/azp run |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables recursive submodule checkout in the GitHub PR validation pipeline so the Samples/WinUIGallery submodule source is available, restoring WinUIGallery sample-build validation on GitHub pull requests.
Context
WinUIGallery is a git submodule ( Samples/WinUIGallery → the public WinUI-Gallery repo). GitHub PR validation previously checked out the superproject only ( git.submodules: false ), so the Gallery source was never present and its build could not run. This is one of the sample-build validation surfaces deferred when GitHub PR validation was first set up.
Change
build/WinUI-GitHub-PR.yml :
The WinUI-Gallery submodule is public, so this requires no private prerequisites. With the source present, the shared build templates build WinUIGallery.slnx on the GitHub PR build stage; the Gallery restores from its own public NuGet feed plus the self-built WinUI component package produced earlier in the build.
Notes
• Scope is WinUIGallery only; other sample apps remain deferred.
• The build/compile signal is independent of Gallery test data; test-data-dependent UI test execution is tracked separately.