Fix cl path for --solution option in out of process mode#5
Merged
Conversation
added 2 commits
June 28, 2026 16:22
ExtractCompileCommandsFromSolution did not plumb clPath into the per-project OutOfProcessExtractor, so --cl-path was silently ignored for --solution input (only --project honored it). Thread clPath through ExtractCompileCommandsFromSolution, WriteCompileCommandsJsonFromSolution, and the two Program.cs solution call sites.
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
itodirel
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--cl-path is not honoured when used in out of process mode
this pr passes cl to
OutOfProcessExtractorwhenExtractCompileCommandsFromSolutionis called