Skip to content

Conversation

@Raymond-MS
Copy link
Contributor

@Raymond-MS Raymond-MS commented Jan 22, 2026

Description

Updated the ARM FF-A libraries to remove global variables for the SEC version as well as to work with the necessary changes for the SEC version. SEC will now query all necessary information while other libraries can rely on the globals set in ArmFfaCommonInit.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Built QEMU SBSA with TPM enabled, verified TPM communication and boot to UEFI shell.

Integration Instructions

N/A

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/202502@ba9f76c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
MdeModulePkg/Library/ArmFfaLib/ArmFfaSecRxTxMap.c 0.00% 32 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaSecLib.c 0.00% 6 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaDxeLib.c 0.00% 3 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaLibBase.c 0.00% 3 Missing ⚠️
MdeModulePkg/Library/ArmFfaLib/ArmFfaPeiLib.c 0.00% 3 Missing ⚠️
...odulePkg/Library/ArmFfaLib/ArmFfaStandaloneMmLib.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             release/202502    #1618   +/-   ##
=================================================
  Coverage                  ?    1.55%           
=================================================
  Files                     ?      637           
  Lines                     ?   234542           
  Branches                  ?      370           
=================================================
  Hits                      ?     3649           
  Misses                    ?   230880           
  Partials                  ?       13           
Flag Coverage Δ
MdeModulePkg 1.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Raymond-MS Raymond-MS force-pushed the personal/rdiaz/TcgStartupLib branch from 0a4027b to 0128ad9 Compare January 22, 2026 21:31
@kuqin12 kuqin12 changed the title [FF-A][TPM] Updates for Tpm2StartupLib [FF-A][TPM] Updates for ArmFfaLib Jan 26, 2026
@kuqin12 kuqin12 changed the title [FF-A][TPM] Updates for ArmFfaLib [FF-A][TPM] Updates for ArmFfaLib to not use global variable pre-memory Jan 26, 2026
@Raymond-MS Raymond-MS requested a review from cfernald January 28, 2026 01:15
@Raymond-MS Raymond-MS force-pushed the personal/rdiaz/TcgStartupLib branch from e101718 to 61c2662 Compare January 28, 2026 23:38
… in each phase's ArmFfaLib implementation. SEC and PEI will query when necessary to avoid setting globals when memory is unavailable.
@Raymond-MS Raymond-MS force-pushed the personal/rdiaz/TcgStartupLib branch from 61c2662 to f81dc04 Compare January 28, 2026 23:57
@Raymond-MS Raymond-MS requested a review from kuqin12 January 29, 2026 00:00
@Raymond-MS
Copy link
Contributor Author

These changes are being upstreamed to EDK2. Once they get merged, I will close this and open another commit pulling down the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants