NetworkPkg/UefiPxeBcDxe: Add UDP Completion Tokens to PXEBC_PRIVATE_DATA #1632
+58
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change tracks UDP completion tokens in the `PXEBC_PRIVATE_DATA` structure, so they are persisted for cleanup in the Stop function in case it is called while a UDP operation is still pending. Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202502 #1632 +/- ##
================================================
Coverage ? 0.55%
================================================
Files ? 165
Lines ? 71965
Branches ? 1755
================================================
Hits ? 402
Misses ? 71556
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
apop5
approved these changes
Feb 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change tracks UDP completion tokens in the
PXEBC_PRIVATE_DATAstructure, so they are persisted for cleanup in the Stop function in case it is called while a UDP operation is still pending.How This Was Tested
EfiPxeBcStop()during UDP readIntegration Instructions
Note: A following PR may apply a similar change to the UDP write functions, but the issue was only observed in the UDP read functions, so this change is applied immediately for the time being.