[CHERRY-PICK] SecurityPkg: AuthVariableLib: Handle empty signature lists#1785
Open
kuqin12 wants to merge 1 commit intomicrosoft:release/202511from
Open
[CHERRY-PICK] SecurityPkg: AuthVariableLib: Handle empty signature lists#1785kuqin12 wants to merge 1 commit intomicrosoft:release/202511from
kuqin12 wants to merge 1 commit intomicrosoft:release/202511from
Conversation
The current implementation fails to set authenticated variables when the signature list is empty. This can legitimately occur for dbx when no signatures are revoked after a certificate rotation. Update the logic to explicitly handle empty signature lists, avoiding an implicit dependency on the variable being absent from variable storage. Signed-off-by: Kun Qin <kun.qin@microsoft.com> (cherry picked from commit b980aa07196a5534581b16563cd78cfc67a74074)
Contributor
✅ QEMU Validation PassedSource Dependencies
Results
Workflow run: https://github.com/microsoft/mu_basecore/actions/runs/25340065273 This comment was automatically generated by the Mu QEMU PR Validation workflow. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1785 +/- ##
================================================
Coverage ? 1.59%
================================================
Files ? 160
Lines ? 37728
Branches ? 172
================================================
Hits ? 601
Misses ? 37127
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The current implementation fails to set authenticated variables when the signature list is empty. This can legitimately occur for dbx when no signatures are revoked after a certificate rotation.
Update the logic to explicitly handle empty signature lists, avoiding an implicit dependency on the variable being absent from variable storage.
(cherry picked from commit b980aa07196a5534581b16563cd78cfc67a74074)
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
This was tested on physical ARM64 platforms and booted to OS desktop and can set empty siglist variable from powershell.
Integration Instructions
N/A