fix: prune old terminal instances#265
Open
nanookclaw wants to merge 2 commits into
Open
Conversation
Author
|
Pushed The failing helper was reading Local verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #261.
This adds an hourly best-effort maintenance pass to the background worker that prunes old terminal workflow history from
df.instancesand the matchingdf.nodesrows. The retention policy is intentionally fixed for now: keep terminal rows for at least 30 days, and always keep the newest 10,000 terminal instances even if they are older.The pruning query runs in one transaction with constraints deferred, ranks only terminal instances (
completed,failed,cancelled) byCOALESCE(completed_at, updated_at, created_at), deletes matching nodes first, then deletes the selected instance rows. Failures are logged and do not stop the worker runtime.A focused pgrx test covers age cutoff, keep-count behavior, nonterminal retention, cancelled/failed/completed statuses, and node cleanup.
Validation
cargo fmt --checkgit diff --checkcargo check --libcould not complete in this environment because pgrx build setup is unavailable:$PGRX_HOME does not exist.