Add missing cache checks to scopeInspection.ts#282
Merged
Conversation
mattmasson
approved these changes
Mar 29, 2026
…licateScopeGeneration # Conflicts: # package-lock.json # package.json
mattmasson
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tryNodeScopeis called once per identifier during validation. Each call walks the ancestry and hitsinspectLetExpression/inspectSection/inspectKeyValuePairs, which callscopeItemFactoryForKeyValuePairstobuild scope entries — an O(n) scan of all sibling bindings.
The problem: this O(n) entry computation ran even when the scope was already cached in
scopeById.assignScopeForNodeIdhas an internal cache check, but the expensive work happened before reaching it. For adocument with N identifiers and B bindings, this produced O(N × B²) total work.
Fix
Add three cache checks to skip
scopeItemFactoryForKeyValuePairswhen the target scope is already inscopeById:inspectKeyValuePairs: skip binding ifscopeById.has(kvp.value.node.id)inspectSection: same guardinspectLetExpression: skipin-expression scope if already cachedBenchmark — Kusto.pq (3,529 lines, 4,220 identifiers)
Operation:
tryNodeScopecalled once per value-context identifier (the hot path invalidateUnknownIdentifiers).Additional connectors
Changes
scopeInspection.ts— 3 lines changed: addedscopeById.has()cache checksscope.test.ts— 2 new tests: cache reuse verification + sub-cubic scaling assertionpackage.json— Version bump to 0.14.0