Skip to content

Remove empty-state helper copy from Home search and keep result-state behavior #11438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwunderl merged 2 commits into from
Jun 29, 2026
Merged

Remove empty-state helper copy from Home search and keep result-state behavior #11438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f591c71
Initial plan
Copilot Jun 26, 2026
fab38fe
Apply remaining changes
Copilot Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 28 additions & 25 deletions webapp/src/projects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,33 @@ export class Projects extends auth.Component<ISettingsProps, ProjectsState> {
? this.getLocalProjectDescription(selectedSearchProjectHeader) || selectedSearchCard?.description
: selectedSearchCard?.description;
const canImport = !!(pxt.appTarget.compile || (pxt.appTarget.cloud && pxt.appTarget.cloud.sharing && pxt.appTarget.cloud.importing)) && !searchMode;
const searchResultsContent = hasSearchQuery
? searchResults.length
? searchResults.map((scr, index) =>
<React.Fragment key={`search-${scr.youTubeId || scr.name || scr.url}-${index}`}>
<ProjectsCodeCard
className={`${scr.projectHeader ? "" : "example"} ${searchSelectedIndex === index ? "selected" : ""}`.trim()}
{ ...scr }
description="" // the description would show up below the card in the view; remove it, shows up in details.
scr={scr.projectHeader || scr} index={index}
onCardClick={this.handleSearchCardClick}
selected={!scr.directOpen ? searchSelectedIndex === index : undefined}
/>
{selectedSearchCard && searchSelectedIndex === index && <div ref="searchDetailView" className="detailview search-detailview">
<ProjectsDetail parent={this.props.parent}
{ ...selectedSearchCard }
name={selectedSearchCard.name}
cardType={selectedSearchCard.cardType}
key={'detailsearch' + selectedSearchCard.name}
description={selectedSearchDescription}
scr={selectedSearchCard}
onClick={this.handleSearchDetailClick}
/>
<sui.CloseButton onClick={this.closeSearchDetail} />
</div>}
</React.Fragment>)
: <p className="ui grey inverted segment">{lf("No search results found.")}</p>
: null;

// lf("Make")
// lf("Code")
Expand Down Expand Up @@ -513,31 +540,7 @@ export class Projects extends auth.Component<ISettingsProps, ProjectsState> {
</div>
{searchMode && <div key={`search_gallerysegment`} className="ui segment gallerysegment search-segment" role="region" aria-label={lf("Search results")}>
<div className="content search-results-grid">
{!hasSearchQuery ? <p className="ui grey inverted segment search-empty-state">{lf("Start typing to search tutorials, examples, and projects.")}</p>
: searchResults.length ? searchResults.map((scr, index) =>
<React.Fragment key={`search-${scr.youTubeId || scr.name || scr.url}-${index}`}>
<ProjectsCodeCard
className={`${scr.projectHeader ? "" : "example"} ${searchSelectedIndex === index ? "selected" : ""}`.trim()}
{ ...scr }
description="" // the description would show up below the card in the view; remove it, shows up in details.
scr={scr.projectHeader || scr} index={index}
onCardClick={this.handleSearchCardClick}
selected={!scr.directOpen ? searchSelectedIndex === index : undefined}
/>
{selectedSearchCard && searchSelectedIndex === index && <div ref="searchDetailView" className="detailview search-detailview">
<ProjectsDetail parent={this.props.parent}
{ ...selectedSearchCard }
name={selectedSearchCard.name}
cardType={selectedSearchCard.cardType}
key={'detailsearch' + selectedSearchCard.name}
description={selectedSearchDescription}
scr={selectedSearchCard}
onClick={this.handleSearchDetailClick}
/>
<sui.CloseButton onClick={this.closeSearchDetail} />
</div>}
</React.Fragment>
) : <p className="ui grey inverted segment">{lf("No search results found.")}</p>}
{searchResultsContent}
</div>
</div>}
{!searchMode && <>
Expand Down
Loading