Add default dim=2 to Cirq QRE qubit manager qalloc APIs#3293
Merged
Conversation
Co-authored-by: fedimser <14271071+fedimser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing default parameter dim=2 in qalloc method
Add default Jun 4, 2026
dim=2 to Cirq QRE qubit-manager qalloc APIs
Co-authored-by: fedimser <14271071+fedimser@users.noreply.github.com>
Copilot
AI
changed the title
Add default
Add default Jun 4, 2026
dim=2 to Cirq QRE qubit-manager qalloc APIsdim=2 to Cirq QRE qubit manager qalloc APIs
fedimser
approved these changes
Jun 4, 2026
msoeken
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cirq interop qubit allocation failed during decomposition/resource-estimation flows when
qalloc(...)was called without an explicitdim, raising a missing-argument error. This updates the affected manager APIs to match expected qubit-default behavior.Scope
qallocsignatures in/source/qdk_package/qdk/qre/interop/_cirq.pyfor:_TypedQubitManagerPeakUsageGreedyQubitManagerBehavioral change
dimto2, allowing call sites that omitdimto allocate standard qubits without error.Result
dimexplicitly are unchanged.qalloc(n)now work as intended.