Basic benchmarking setup with Criterion#408
Merged
anakrish merged 2 commits intomicrosoft:mainfrom May 14, 2025
Merged
Conversation
Collaborator
|
@unexge @balcanuc Thanks for the benchmark! Looking forward to your findings and patterns of writing policy. Regorus doesn't do many possible optimizations yet (e.g. hoist common sub-expressions out of loops, fold-constants). The examples you provide will be a good motivator for prioritizing what to implement first. |
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
Signed-off-by: Burak Varlı <burakvar@amazon.co.uk>
anakrish
approved these changes
May 14, 2025
Collaborator
Contributor
Author
anakrish
pushed a commit
to anakrish/regorus
that referenced
this pull request
May 21, 2025
* Basic benchmarking setup with Criterion * Fix Clippy warnings Signed-off-by: Burak Varlı <burakvar@amazon.co.uk> Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds basic benchmarking setup using Criterion.rs. This would be useful to do performance analyses, and also to measure potential performance optimizations.
Main motivation for this PR was to understand how Regorus handles constants vs. data. @balcanuc realized that constants are re-evaluated each time and that was causing noticeable performance differences on sets with ~100 elements compared to ~3000 elements. This seems to be only happen with constants and not with data:

We're trying to get more data and plan to create an issue to discuss in more details.
The benchmarks can be run with
cargo bench. Sample output:Criterion also generates HTML reports and graphs automatically, which can be found at
./target/criterion/report/index.html.