-
Notifications
You must be signed in to change notification settings - Fork 92
Corrected version to 0.236.011 #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adjusts the app version and adds fix documentation around retention-policy “NotFound” deletion behavior.
Changes:
- Adds fix documentation for handling Cosmos
NotFoundrace conditions during retention deletions. - Updates
application/single_app/config.pyVERSION to0.236.011.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/explanation/fixes/v0.236.011/RETENTION_POLICY_NOTFOUND_FIX.md | New fix write-up describing retention deletion NotFound handling and testing notes. |
| application/single_app/config.py | Changes the global app VERSION constant. |
Comments suppressed due to low confidence (55)
application/single_app/config.py:539
- Variable enable_video_file_support is not used.
enable_video_file_support = settings.get("enable_video_file_support")
application/single_app/config.py:540
- Variable enable_audio_file_support is not used.
enable_audio_file_support = settings.get("enable_audio_file_support")
application/single_app/config.py:5
- Module 'uuid' is imported with both 'import' and 'import from'.
import uuid
application/single_app/config.py:9
- Module 'threading' is imported with both 'import' and 'import from'.
import threading
application/single_app/config.py:2
- Import of 'logging' is not used.
import logging
application/single_app/config.py:4
- Import of 'requests' is not used.
import requests
application/single_app/config.py:5
- Import of 'uuid' is not used.
import uuid
application/single_app/config.py:6
- Import of 'tempfile' is not used.
import tempfile
application/single_app/config.py:7
- Import of 'json' is not used.
import json
application/single_app/config.py:8
- Import of 'time' is not used.
import time
application/single_app/config.py:10
- Import of 'random' is not used.
import random
application/single_app/config.py:12
- Import of 'markdown2' is not used.
import markdown2
application/single_app/config.py:13
- Import of 're' is not used.
import re
application/single_app/config.py:14
- Import of 'docx' is not used.
import docx
application/single_app/config.py:15
- Import of 'fitz' is not used.
import fitz # PyMuPDF
application/single_app/config.py:16
- Import of 'math' is not used.
import math
application/single_app/config.py:17
- Import of 'mimetypes' is not used.
import mimetypes
application/single_app/config.py:18
- Import of 'openpyxl' is not used.
import openpyxl
application/single_app/config.py:19
- Import of 'xlrd' is not used.
import xlrd
application/single_app/config.py:20
- Import of 'traceback' is not used.
import traceback
application/single_app/config.py:21
- Import of 'subprocess' is not used.
import subprocess
application/single_app/config.py:24
- Import of 'ffmpeg_py' is not used.
import ffmpeg as ffmpeg_py
application/single_app/config.py:25
- Import of 'glob' is not used.
import glob
application/single_app/config.py:26
- Import of 'jwt' is not used.
import jwt
application/single_app/config.py:27
- Import of 'pandas' is not used.
import pandas
application/single_app/config.py:45
- Import of 'Flask' is not used.
Import of 'flash' is not used.
Import of 'request' is not used.
Import of 'jsonify' is not used.
Import of 'render_template' is not used.
Import of 'redirect' is not used.
Import of 'url_for' is not used.
Import of 'session' is not used.
Import of 'send_from_directory' is not used.
Import of 'send_file' is not used.
Import of 'Markup' is not used.
Import of 'current_app' is not used.
from flask import (
Flask,
flash,
request,
jsonify,
render_template,
redirect,
url_for,
session,
send_from_directory,
send_file,
Markup,
current_app
)
application/single_app/config.py:46
- Import of 'secure_filename' is not used.
from werkzeug.utils import secure_filename
application/single_app/config.py:47
- Import of 'datetime' is not used.
Import of 'timezone' is not used.
Import of 'timedelta' is not used.
from datetime import datetime, timezone, timedelta
application/single_app/config.py:48
- Import of 'wraps' is not used.
from functools import wraps
application/single_app/config.py:49
- Import of 'ConfidentialClientApplication' is not used.
Import of 'SerializableTokenCache' is not used.
from msal import ConfidentialClientApplication, SerializableTokenCache
application/single_app/config.py:50
- Import of 'Session' is not used.
from flask_session import Session
application/single_app/config.py:51
- Import of 'uuid4' is not used.
from uuid import uuid4
application/single_app/config.py:52
- Import of 'Thread' is not used.
from threading import Thread
application/single_app/config.py:53
- Import of 'AzureOpenAI' is not used.
Import of 'RateLimitError' is not used.
from openai import AzureOpenAI, RateLimitError
application/single_app/config.py:54
- Import of 'Fernet' is not used.
Import of 'InvalidToken' is not used.
from cryptography.fernet import Fernet, InvalidToken
application/single_app/config.py:55
- Import of 'quote' is not used.
from urllib.parse import quote
application/single_app/config.py:56
- Import of 'Executor' is not used.
from flask_executor import Executor
application/single_app/config.py:57
- Import of 'BeautifulSoup' is not used.
from bs4 import BeautifulSoup
application/single_app/config.py:62
- Import of 'RecursiveCharacterTextSplitter' is not used.
Import of 'MarkdownHeaderTextSplitter' is not used.
Import of 'RecursiveJsonSplitter' is not used.
from langchain_text_splitters import (
RecursiveCharacterTextSplitter,
MarkdownHeaderTextSplitter,
RecursiveJsonSplitter
)
application/single_app/config.py:63
- Import of 'Image' is not used.
from PIL import Image
application/single_app/config.py:64
- Import of 'BytesIO' is not used.
from io import BytesIO
application/single_app/config.py:65
- Import of 'List' is not used.
from typing import List
application/single_app/config.py:67
- Import of 'exceptions' is not used.
from azure.cosmos import CosmosClient, PartitionKey, exceptions
application/single_app/config.py:68
- Import of 'CosmosResourceNotFoundError' is not used.
from azure.cosmos.exceptions import CosmosResourceNotFoundError
application/single_app/config.py:71
- Import of 'DocumentAnalysisClient' is not used.
from azure.ai.formrecognizer import DocumentAnalysisClient
application/single_app/config.py:72
- Import of 'IndexDocumentsBatch' is not used.
from azure.search.documents import SearchClient, IndexDocumentsBatch
application/single_app/config.py:73
- Import of 'VectorizedQuery' is not used.
from azure.search.documents.models import VectorizedQuery
application/single_app/config.py:74
- Import of 'SearchIndexClient' is not used.
from azure.search.documents.indexes import SearchIndexClient
application/single_app/config.py:75
- Import of 'SearchIndex' is not used.
Import of 'SearchField' is not used.
Import of 'SearchFieldDataType' is not used.
from azure.search.documents.indexes.models import SearchIndex, SearchField, SearchFieldDataType
application/single_app/config.py:76
- Import of 'AzureError' is not used.
Import of 'ResourceNotFoundError' is not used.
Import of 'HttpResponseError' is not used.
Import of 'ServiceRequestError' is not used.
from azure.core.exceptions import AzureError, ResourceNotFoundError, HttpResponseError, ServiceRequestError
application/single_app/config.py:77
- Import of 'LROPoller' is not used.
from azure.core.polling import LROPoller
application/single_app/config.py:78
- Import of 'CognitiveServicesManagementClient' is not used.
from azure.mgmt.cognitiveservices import CognitiveServicesManagementClient
application/single_app/config.py:79
- Import of 'ClientSecretCredential' is not used.
Import of 'get_bearer_token_provider' is not used.
from azure.identity import ClientSecretCredential, DefaultAzureCredential, get_bearer_token_provider, AzureAuthorityHosts
application/single_app/config.py:81
- Import of 'AnalyzeTextOptions' is not used.
Import of 'TextCategory' is not used.
from azure.ai.contentsafety.models import AnalyzeTextOptions, TextCategory
application/single_app/config.py:82
- Import of 'generate_blob_sas' is not used.
Import of 'BlobSasPermissions' is not used.
from azure.storage.blob import BlobServiceClient, generate_blob_sas, BlobSasPermissions
| EXECUTOR_MAX_WORKERS = 30 | ||
| SESSION_TYPE = 'filesystem' | ||
| VERSION = "0.236.012" | ||
| VERSION = "0.236.011" |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERSION is being decreased to 0.236.011, but there are already retention-policy changes/tests that expect the app version to be >= 0.236.012 (e.g., functional_tests/test_retention_policy_notfound_handling.py checks for >= 0.236.012). This will cause the functional test suite to fail and makes versioning non-monotonic. Please bump VERSION forward (at least back to 0.236.012, or the next patch) to match the existing implementation/docs/tests.
| VERSION = "0.236.011" | |
| VERSION = "0.236.012" |
* updated the logging logic when running retention delete with archiving enabled (#642) * Corrected version to 0.236.011 (#645) * v0.237.001 (#649) * Use Microsoft python base image * Add python ENV vars * Add python ENV vars * Install deps to systme * Add temp dir to image and pip conf support * Add custom-ca-certificates dir * Logo bug fix (#654) * release note updating for github coplilot * fixed logo bug issue * added 2,3,4,5,6,14 days to rentention policy * added retention policy time updates --------- Co-authored-by: Ed Clark <clarked@microsoft.com> Co-authored-by: Bionic711 <13358952+Bionic711@users.noreply.github.com>
* updated the logging logic when running retention delete with archiving enabled (#642) * Corrected version to 0.236.011 (#645) * v0.237.001 (#649) * Use Microsoft python base image * Add python ENV vars * Add python ENV vars * Install deps to systme * Add temp dir to image and pip conf support * Add custom-ca-certificates dir * Logo bug fix (#654) * release note updating for github coplilot * fixed logo bug issue * added 2,3,4,5,6,14 days to rentention policy * added retention policy time updates * Rentention policy (#657) * Critical Retention Policy Deletion Fix * Create RETENTION_POLICY_NULL_LAST_ACTIVITY_FIX.md --------- Co-authored-by: Ed Clark <clarked@microsoft.com> Co-authored-by: Bionic711 <13358952+Bionic711@users.noreply.github.com>
No description provided.