Fix ValueError in iou calculation due to PyMuPDF Rect initialization (src/grits.py)#205
Open
KimRass wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix ValueError in iou calculation due to PyMuPDF Rect initialization (src/grits.py)#205KimRass wants to merge 1 commit intomicrosoft:mainfrom
KimRass wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, when computing GriTS metrics (e.g.,
grits_toporfactored_2dmss), aValueErroris raised in theioufunction insrc/grits.pywhen using recent versions ofPyMuPDF(fitz):Motivation/Root Cause:
This issue occurs because the
ioufunction frequently receives 1D NumPy arrays forbbox1andbbox2. While older versions ofPyMuPDFmight have handled this seamlessly, newer versions fail to automatically unpack 1D NumPy arrays when initializing aRectobject, interpreting the input as a single element instead of 4 coordinate values.Changes proposed in this pull request:
bbox1andbbox2to Python lists before passing them toRect()in theioufunction insrc/grits.py.Rect(bbox1)toRect(list(bbox1)).intersect(bbox2)to.intersect(list(bbox2))(and similarly for.include_rect).Impact:
This minor modification ensures robust compatibility with newer versions of the
PyMuPDFlibrary without altering the underlying logic or performance of the GriTS metric calculations.