Fix/optional activity id conversation resource #272
+120
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The activity_id field in ConversationResource is now optional to match the actual API behavior. When creating a conversation without an initial activity, the Teams API does not include activityId in the response, which was causing validation errors. Changes: - Made activity_id Optional[str] with default None in ConversationResource - Updated mock transport to conditionally include activityId based on request body - Added test case for creating conversation without activity Fixes validation error when creating conversations without activities.
Author
|
@microsoft-github-policy-service agree |
lilyydu
reviewed
Feb 10, 2026
Collaborator
lilyydu
left a comment
lilyydu
left a comment
There was a problem hiding this comment.
Thank you for catching and filing this! Just a comment about splitting the test cases :)
| assert response.service_url is not None | ||
|
|
||
| @pytest.mark.asyncio | ||
| async def test_conversation_resource_optional_fields(self): |
Collaborator
There was a problem hiding this comment.
please split these into 4 different test cases
Author
There was a problem hiding this comment.
sure, made the changes now :)
lilyydu
reviewed
Feb 11, 2026
| assert response.activity_id is None | ||
| assert response.service_url is not None | ||
|
|
||
| async def test_conversation_resource_with_all_fields(self): |
Collaborator
There was a problem hiding this comment.
tests seem to be failing b/c these methods are missing @pytest.mark.asyncio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a validation error in
ConversationResourcewhen creating conversations without an initial activity.Problem
The
activity_idandservice_urlfield was required in theConversationResourcemodel but seems they are not returned from the api and thus we keep getting error:Seems
teams.netalready has it adapted - hereSolution
activity_idandservice_urloptional (Optional[str] = None) inConversationResourceactivityIdbased on request contentTesting
test_create_conversation_without_activityto verify the fixtest_create_conversationstill validates the activity scenario