Skip to content

[test-improver] test: add DataTestMethod edge cases for TypeContainingTestMethodShouldBeATestClassAnalyzer (MSTEST0030) #9092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Evangelink wants to merge 1 commit into
base: main
Choose a base branch
from
+68 −0
Draft

[test-improver] test: add DataTestMethod edge cases for TypeContainingTestMethodShouldBeATestClassAnalyzer (MSTEST0030) #9092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions ...sts/MSTest.Analyzers.UnitTests/TypeContainingTestMethodShouldBeATestClassAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,4 +462,72 @@ public void TestMethod1()

await VerifyCS.VerifyCodeFixAsync(code, fixedCode);
}

[TestMethod]
public async Task WhenNonTestClassHasDataTestMethod_Diagnostic()
{
string code = """
using Microsoft.VisualStudio.TestTools.UnitTesting;

public class [|MyTestClass|]
{
[DataTestMethod]
[DataRow(1)]
public void TestMethod1(int value) {}
}
""";

string fixedCode = """
using Microsoft.VisualStudio.TestTools.UnitTesting;

[TestClass]
public class MyTestClass
{
[DataTestMethod]
[DataRow(1)]
public void TestMethod1(int value) {}
}
""";

await VerifyCS.VerifyCodeFixAsync(code, fixedCode);
}

[TestMethod]
public async Task WhenNonTestClassInheritsDataTestMethodFromAbstractBase_Diagnostic()
{
// Abstract base is exempt from the diagnostic; derived non-test class
// that inherits [DataTestMethod] via the inheritance walk should fire.
string code = """
using Microsoft.VisualStudio.TestTools.UnitTesting;

public abstract class AbstractBase
{
[DataTestMethod]
[DataRow(1)]
public void TestMethod1(int value) {}
}

public class [|MyTestClass|] : AbstractBase
{
}
""";

string fixedCode = """
using Microsoft.VisualStudio.TestTools.UnitTesting;

public abstract class AbstractBase
{
[DataTestMethod]
[DataRow(1)]
public void TestMethod1(int value) {}
}

[TestClass]
public class MyTestClass : AbstractBase
{
}
""";

await VerifyCS.VerifyCodeFixAsync(code, fixedCode);
}
}