Resolve code lenses, request inlay hints.#195
Merged
DanielRosenwasser merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
gabritto
reviewed
Feb 23, 2026
| const inlayHintsPromise = request("textDocument/inlayHint", { | ||
| textDocument: { uri: openFileUri }, | ||
| // TODO - this is still a hack. | ||
| // Could just move it to the end after we've iterated through the file. |
Member
Author
There was a problem hiding this comment.
Because clients and servers are supposed to agree not to index past any given line's length. Instead of counting the lines of the file up front and calculating a line map, I just used the character position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed we weren't requesting anything for formatting, and weren't actually resolving the code lenses.
Disclaimer: I haven't tested it locally yet.