-
Notifications
You must be signed in to change notification settings - Fork 941
Port #63038: Consult referenced project options for synthetic default export eligibility #2752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jakebailey
merged 2 commits into
main
from
copilot/fix-synthetic-default-export-eligibility
Feb 12, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70 changes: 70 additions & 0 deletions
70
...ctReferences/referenced-project-with-esnext-module-disallows-synthetic-default-imports.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| currentDirectory::/home/src/workspaces/project | ||
| useCaseSensitiveFileNames::true | ||
| Input:: | ||
| //// [/home/src/workspaces/project/app/index.ts] *new* | ||
| import TestSrc from '../lib/src/utils'; // Error | ||
| import TestDecl from '../lib/dist/utils'; // Error | ||
| console.log(TestSrc.test()); | ||
| console.log(TestDecl.test()); | ||
| //// [/home/src/workspaces/project/app/tsconfig.json] *new* | ||
| { | ||
| "compilerOptions": { | ||
| "module": "esnext", | ||
| "moduleResolution": "bundler" | ||
| }, | ||
| "references": [ | ||
| { "path": "../lib" } | ||
| ] | ||
| } | ||
| //// [/home/src/workspaces/project/lib/dist/utils.d.ts] *new* | ||
| export declare const test: () => string; | ||
| //// [/home/src/workspaces/project/lib/src/utils.ts] *new* | ||
| export const test = () => 'test'; | ||
| //// [/home/src/workspaces/project/lib/tsconfig.json] *new* | ||
| { | ||
| "compilerOptions": { | ||
| "composite": true, | ||
| "declaration": true, | ||
| "module": "esnext", | ||
| "moduleResolution": "bundler", | ||
| "rootDir": "src", | ||
| "outDir": "dist" | ||
| }, | ||
| "include": ["src"] | ||
| } | ||
|
|
||
| tsgo --p app --pretty false | ||
| ExitStatus:: DiagnosticsPresent_OutputsGenerated | ||
| Output:: | ||
| app/index.ts(1,8): error TS1192: Module '"/home/src/workspaces/project/lib/dist/utils"' has no default export. | ||
| app/index.ts(2,8): error TS1192: Module '"/home/src/workspaces/project/lib/dist/utils"' has no default export. | ||
| //// [/home/src/tslibs/TS/Lib/lib.es2025.full.d.ts] *Lib* | ||
| /// <reference no-default-lib="true"/> | ||
| interface Boolean {} | ||
| interface Function {} | ||
| interface CallableFunction {} | ||
| interface NewableFunction {} | ||
| interface IArguments {} | ||
| interface Number { toExponential: any; } | ||
| interface Object {} | ||
| interface RegExp {} | ||
| interface String { charAt: any; } | ||
| interface Array<T> { length: number; [n: number]: T; } | ||
| interface ReadonlyArray<T> {} | ||
| interface SymbolConstructor { | ||
| (desc?: string | number): symbol; | ||
| for(name: string): symbol; | ||
| readonly toStringTag: symbol; | ||
| } | ||
| declare var Symbol: SymbolConstructor; | ||
| interface Symbol { | ||
| readonly [Symbol.toStringTag]: string; | ||
| } | ||
| declare const console: { log(msg: any): void; }; | ||
| //// [/home/src/workspaces/project/app/index.js] *new* | ||
| import TestSrc from '../lib/src/utils'; // Error | ||
| import TestDecl from '../lib/dist/utils'; // Error | ||
| console.log(TestSrc.test()); | ||
| console.log(TestDecl.test()); | ||
|
|
||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
GetProjectReferenceFromOutputDts(...) != nilcheck appears redundant here:Program.GetRedirectForResolutionalready consults both the source-to-output and output-dts-to-source project reference maps (and symlink mapping). Dropping the extra lookup would simplify the condition and avoid implying there are two independent mechanisms to check.