-
Notifications
You must be signed in to change notification settings - Fork 334
eng, require changelog for java client emitter #9421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
eng, require changelog for java client emitter #9421
Conversation
|
No changes needing a change description found. |
|
You can try these changes here
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always finding myself looking for chronus command..
Maybe a custom script like python?
typespec/packages/http-client-python/package.json
Lines 45 to 46 in 6af7040
| "change:version": "pnpm chronus version --ignore-policies --only @typespec/http-client-python", | |
| "change:add": "pnpm chronus add", |
Not sure for change:add, whether we could do pnpm chronus add @typespec/http-client-java.
Yeah, we can certainly add that to our context, if it would be easier for human to handle. |
|
LGTM. Just to clarify my understanding: this changelog is for unbranded emitter only, not for branded emitter (https://github.com/Azure/autorest.java/blob/main/typespec-extension/changelog.md), but the changes will include both branded and unbranded changes. Does my understanding correct? |
|
Yes. The changelog is for unbranded only. Most changes be common to both unbranded and branded (unless it only target e.g. Azure.ResourceManager tsp lib that unbranded definitely won't use). |
Java client emitter would use the chronus to organize changelog.