Reenable and improve vscode e2e tests #9428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
ide
commit: |
Contributor
|
All changed packages have been documented.
|
Collaborator
|
You can try these changes here
|
timotheeguerin
force-pushed
the
reneable-vscode-e2e
branch
from
addbf9f to
e32ee6b
Compare
timotheeguerin
requested review from
AlitzelMendez,
RodgeFu,
bterlson,
chrisradek,
lirenhe,
markcowl and
witemple-msft
as code owners
zedy-wj
reviewed
Jan 22, 2026
| let resLength = 0; | ||
| if (fs.existsSync(dir)) { | ||
| resLength = fs.readdirSync(dir).length; | ||
| await rm(cs.caseDir, { recursive: true }); |
There was a problem hiding this comment.
This doesn’t seem to impact the test results, but I wanted to double-check whether this behavior is expected. The screenshots in the temp folder are no longer being cleaned up.
Member
Author
There was a problem hiding this comment.
Yeah, meant to leave a comment to ask. What was the purpose to clean this up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable and cleanup for #9354