Add support for array encoding with @encode(ArrayEncoding.*) decorator #9430
+246
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Contributor
|
No changes needing a change description found. |
radhgupta
force-pushed
the
csv-encoding
branch
from
e7bb9b0 to
fbbfaf5
Compare
| IsDiscriminator = isDiscriminator; | ||
| IsHttpMetadata = isHttpMetadata; | ||
| SerializationOptions = serializationOptions; | ||
| Encode = encode; |
Contributor
There was a problem hiding this comment.
I think we should follow the same pattern we use for other encoding formats. We can define a new ArrayKnownEncoding enum and add each of the possible values and then flow this through to a SerializationFormat. See https://github.com/microsoft/typespec/blob/main/packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator/src/TypeFactory.cs#L340
| public bool IsNullable { get; } | ||
| public bool IsDiscriminator { get; } | ||
| public bool IsHttpMetadata { get; } | ||
| public string? Encode { get; } |
Contributor
There was a problem hiding this comment.
This would instead be the _serializationFormat on the PropertyProvider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for custom array encoding formats in the C# HTTP client generator, allowing arrays to be serialized and deserialized using delimiters such as comma, space, pipe, or newline. The changes span the model, serialization logic, type conversion, and test coverage to ensure correct handling of these encodings.
Array encoding support
encodeproperty toInputModelPropertyand related types to specify the desired array encoding (e.g.,commaDelimited,spaceDelimited, etc.). This is reflected in the type definitions, model constructors, and JSON serialization/deserialization logic.type-converter.ts) to propagate theencodeproperty from SDK model properties into the input model.Serialization and deserialization logic
MrwSerializationTypeDefinition.csto handle arrays with specified encodings. These methods join or split array elements using the appropriate delimiter and handle both string and primitive element types.Test coverage
EncodeArrayTests.csto verify correct serialization and deserialization for each supported encoding format (comma, space, pipe, newline).Implements: #9028