Add a the ability to search upward for a Unity project#233
Open
mister-liss wants to merge 1 commit intomicrosoft:developfrom
Open
Add a the ability to search upward for a Unity project#233mister-liss wants to merge 1 commit intomicrosoft:developfrom
mister-liss wants to merge 1 commit intomicrosoft:developfrom
Conversation
jwittner
requested changes
Jun 15, 2022
| [switch] $Recurse, | ||
|
|
||
| [parameter(Mandatory = $false, ParameterSetName = "RecurseUp")] | ||
| [switch] $RecurseUp |
Member
There was a problem hiding this comment.
Something about RecurseUp hurts me. Maybe IncludeParent\s??
| [switch] $Recurse | ||
| [switch] $Recurse, | ||
|
|
||
| [parameter(Mandatory = $false, ParameterSetName = "RecurseUp")] |
Member
There was a problem hiding this comment.
We could include this behavior without restricting the others. Is there a strong reason to use the parameter set name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have cases in our CI in which it is important to know if a file is part of a Unity project and to recover the project path if it is.