Skip to content

[many ports 3] Include <chrono> for system_clock and high_resolution_clock#42406

Merged
BillyONeal merged 2 commits intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/testmsvc
Dec 2, 2024
Merged

[many ports 3] Include <chrono> for system_clock and high_resolution_clock#42406
BillyONeal merged 2 commits intomicrosoft:masterfrom
Cheney-W:Dev/Cheney/testmsvc

Conversation

@Cheney-W
Copy link
Contributor

Due to there are new changes merged by microsoft/STL#5105, so ports zlmediakit wampcc realsense2 openvino and omplapp need to include <chrono> by patching to fix the following errors:

error C2039: 'high_resolution_clock': is not a member of 'std::chrono'
error C2039: 'high_resolution_clock': is not a member of 'std::chrono'

StephanTLavavej has already submitted a PR: realsenseai/librealsense#13537 to realsense2's upstream.

The other ports have submitted relevant PRs upstream. The list is as follows:
ZLMediaKit/ZLToolKit#258
darrenjs/wampcc#85
openvinotoolkit/openvino#27782
ompl/ompl#1201

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Nov 28, 2024
@BillyONeal BillyONeal changed the title [many ports 3] Include <chrono> for system_clock and high_resolution_clock [many ports 3] Include <chrono> for system_clock and high_resolution_clock Nov 28, 2024
@Cheney-W Cheney-W marked this pull request as ready for review November 29, 2024 06:17
@LilyWangLL LilyWangLL added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Nov 29, 2024
@BillyONeal
Copy link
Member

Thanks!

@BillyONeal BillyONeal merged commit 887288b into microsoft:master Dec 2, 2024
@Cheney-W Cheney-W deleted the Dev/Cheney/testmsvc branch December 2, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants