Replace elegant-spinner with ora (default settings)#109
Closed
Replace elegant-spinner with ora (default settings)#109
Conversation
Agent-Logs-Url: https://github.com/microsoft/vscode-azurecli/sessions/d24d83be-c554-49f5-8d50-06abf7d9347f Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
rzhao271
April 1, 2026 23:55
View session
|
@copilot Use the latest version of ora instead. |
Agent-Logs-Url: https://github.com/microsoft/vscode-azurecli/sessions/c358cc1a-22e5-4573-b408-c1f9e67a4c73 Co-authored-by: rzhao271 <7199958+rzhao271@users.noreply.github.com>
Contributor
Author
Updated to ora 9.3.0 in commit |
|
Closing as wontfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
elegant-spinnerdependency withora@9.3.0(latest) using its default settings.Changes
package.json: Swappedelegant-spinner: 2.0.0forora: 9.3.0independenciestsconfig.json: Changed"module"to"node16"and added"moduleResolution": "node16"so TypeScript emits a true dynamicimport()expression (rather than compiling it torequire()), enabling the CJS extension host to load the ESM-only ora packagesrc/extension.ts: Replaced the staticrequire-style import with a dynamicimport('ora')call in the constructor; the resolvedOrainstance'sframe()method is stored as aspinnerFramefunction reference and used in place of the previousstatusBarSpinner.frame()callsSince ora v5+, the package is ESM-only. The
frame()method returns the next spinner frame string and remains a drop-in replacement for the previouselegant-spinnerbehaviour.