Skip to content

Bump Node to 24.17.0 to match consuming extensions#75

Merged
edvilme merged 2 commits into
mainfrom
bump-nvmrc-24.17.0
Jul 2, 2026
Merged

Bump Node to 24.17.0 to match consuming extensions#75
edvilme merged 2 commits into
mainfrom
bump-nvmrc-24.17.0

Conversation

@edvilme

@edvilme edvilme commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps the pinned Node version in .nvmrc from 22.21.1 to 24.17.0 to align the shared package's Node toolchain with the extensions that consume it.

Why

All five VS Code Python tool extensions (black-formatter, flake8, isort, mypy, pylint) currently pin 24.17.0 in their .nvmrc. When an extension integrates this package as a git submodule, it builds this package's TypeScript during npm install using the extension's Node version. Keeping this repo on 22.21.1 means the shared package is developed/tested under an older Node than it is actually built with downstream.

A new consistency check in the extensions' shared-package-submodule-sync workflow fails a sync if the extension's .nvmrc is older than this package's .nvmrc. Bumping here keeps the two in lockstep and avoids drift.

Change

  • .nvmrc: 22.21.1 -> 24.17.0

@rchiodo

rchiodo commented Jul 2, 2026

Copy link
Copy Markdown

🔒 Automated review in progress — @rchiodo is auto-reviewing this PR.

rchiodo
rchiodo previously approved these changes Jul 2, 2026

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme edvilme added the debt Code Cleanup, Refactorings and Repo health. Not feature related label Jul 2, 2026
Bump the patch version across VERSION, package.json, pyproject.toml, and
package-lock.json alongside the Node toolchain update in this PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread VERSION

@rchiodo rchiodo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme edvilme merged commit 8a52ffc into main Jul 2, 2026
20 checks passed
@edvilme edvilme deleted the bump-nvmrc-24.17.0 branch July 2, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code Cleanup, Refactorings and Repo health. Not feature related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants