Skip to content

feat: Add Fabric support with new tree node providers and experiences#2921

Open
bk201- wants to merge 32 commits into
mainfrom
dev/bk201-/supporting-fabric
Open

feat: Add Fabric support with new tree node providers and experiences#2921
bk201- wants to merge 32 commits into
mainfrom
dev/bk201-/supporting-fabric

Conversation

@bk201-

@bk201- bk201- commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

This pull request introduces improvements for Cosmos DB integration and workspace management, including enhanced error handling, expanded localization, and support for new workspace views. It also updates dependencies and refines command activation conditions for better compatibility with the vscode-fabric.view.workspace. The changes are primarily focused on user experience, workspace integration, and dependency maintenance.

Workspace and Cosmos DB Integration:

  • Added support for the vscode-fabric.view.workspace view in package.json, enabling Cosmos DB commands and features to be activated in this new workspace context. [1] [2] [3]
  • Expanded command activation conditions to include vscode-fabric.view, ensuring Cosmos DB actions are available in both Azure and Fabric workspace views. [1] [2]

Localization and Error Handling Improvements:

  • Added new localized strings for artifact, workspace, and database errors, as well as improved validation messages for names and credentials in l10n/bundle.l10n.json. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]
  • Removed unused or outdated localization strings related to graph resources, reflecting a shift away from graph-specific features. [1] [2] [3] [4]

Dependency Updates:

  • Updated several dependencies in package.json, including eslint-plugin-jest, jest-mock-vscode, typescript-eslint, and added @microsoft/vscode-fabric-api for Fabric workspace support. [1] [2] [3] [4]

Codebase Cleanup:

  • Simplified the activate function in main.ts by removing performance stats tracking and adjusting the return type to allow for void, streamlining extension activation. [1] [2]

Dependency Overrides:

  • Added an override for @prantlf/jsonlint to use a specific version of ajv, ensuring compatibility and stability.

@bk201- bk201- marked this pull request as ready for review March 4, 2026 15:27
@bk201- bk201- requested a review from a team as a code owner March 4, 2026 15:27
mkrueger
mkrueger previously approved these changes Apr 14, 2026
# Conflicts:
#	l10n/bundle.l10n.json
#	src/constants.ts
#	src/extension.ts
bk201- and others added 5 commits April 16, 2026 13:43
# Conflicts:
#	l10n/bundle.l10n.json
#	package-lock.json
#	src/commands/createContainer/CosmosDBExecuteStep.ts
#	src/commands/deleteContainer/deleteContainer.ts
#	src/commands/deleteItems/deleteItems.ts
#	src/commands/filterTreeItems/filterTreeItems.ts
#	src/commands/openNoSqlQueryEditor/openNoSqlQueryEditor.ts
#	src/commands/sortTreeItems/sortTreeItems.ts
#	src/constants.ts
#	src/extension.ts
#	src/extensionVariables.ts
bk201- added 2 commits May 20, 2026 14:19
…-role

Workaround for oxc-project/oxc#19395 (fixed-size allocator pool memory panic on Windows):

- Bump oxlint ~1.51.0 -> ~1.66.0 and oxlint-tsgolint ~0.22.1 -> ~0.23.0

- Cap oxlint parallelism with --threads=4 in lint and lint-fix scripts to keep total reserved virtual address space within Windows commit limits

Fix accessibility errors surfaced by the upgraded ruleset:

- MigrationAssistant: replace 5 occurrences of role=status (Text/div) with the native <output> element which has implicit role=status and aria-live=polite

- MigrationAssistant: disable prefer-tag-over-role on the composite SVG icon <span role=img> (native <img> cannot wrap a Fluent SVG component)

- GenerateQueryInput: disable prefer-tag-over-role on the like/dislike rating <div role=group> (fieldset would impose default border/padding/margin and break the inline flex layout)
Resolves residual diffs after merging main into the supporting-fabric branch. No behavior changes intended; touches imports, types, and minor refactors carried over from main.

Validation: npm run l10n, npm run prettier-fix, npm run lint (oxlint + eslint) all pass with 0 errors.
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

🎉 Build Summary

🔗 Source

📦 Package Information

🧪 Test Results

  • Unit Tests: ✅ success
  • Integration Tests: ✅ success

✅ Build Status

All checks completed successfully!

bk201- added 2 commits June 9, 2026 12:15
# Conflicts:
#	package-lock.json
#	package.json
#	src/tree/cosmosdb/AccountInfo.ts
#	src/webviews/cosmosdb/Migration/state/MigrationChannel.ts
#	src/webviews/cosmosdb/QueryEditor/QueryPanel/GenerateQueryInput.tsx
languy
languy previously approved these changes Jun 10, 2026
@@ -0,0 +1,11 @@
/*---------------------------------------------------------------------------------------------

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is it really necessary to have a single file for each model? It doesn't matter much, since everything will be bundled, but it's a bit easier to read code if everything is in one file.

@github-actions

Copy link
Copy Markdown
Contributor

🔬 NoSQL language-service integration

Commit: 9537ac9
Pull Request: #2921 feat: Add Fabric support with new tree node providers and experiences

🧪 Result

  • NoSQL integration tests: ✅ success

📥 Artifacts (run)

@github-actions

Copy link
Copy Markdown
Contributor

🎭 E2E Tests (Playwright + VS Code)

Commit: 9537ac9
Pull Request: #2921 feat: Add Fabric support with new tree node providers and experiences

🧪 Result

  • E2E Tests: ✅ success

📥 Artifacts (run)

Tip: the HTML report artifact contains a self-contained Playwright report.
Download the zip, extract, and open index.html — or run
npx playwright show-report <extracted-dir> for the interactive view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants