removal of LLM instructions deployment logic by languy · Pull Request #3126 · microsoft/vscode-cosmosdb

languy · 2026-06-04T09:56:22Z

Remove logic and setting for deploying or removing LLM instructions.
Remove LLM instructions if the md5 hash match the original instructions that were deployed and remove deployment manifest from global storage.
Fixes #3125.

sevoku · 2026-06-08T20:09:24Z

@copilot backport this PR to rel/0.34

Copilot · 2026-06-08T20:11:28Z

@copilot backport this PR to rel/0.34

I couldn’t run the backport flow because gh auth status failed in the agent (GITHUB_TOKEN is invalid). Please refresh agent GitHub auth/re-run the task, and I can backport this PR to rel/0.34 immediately.

…gent The Phase A 'abort if gh unauthenticated' gate caused the GitHub.com cloud agent to bail out of a backport before doing any git work when 'gh auth status' reported GITHUB_TOKEN invalid (see #3126). In the cloud agent, git push auth comes from the platform credential helper and the PR is opened by the platform - neither needs gh. Add a cloud-agent override so a failing 'gh auth status' no longer stops the backport; only PR-metadata edits need gh, with GH_TOKEN retry and REST API fallbacks.

sevoku

Sorry for the Copilot noise, I was hoping the backport agent would work now, but it doesn't as expected.

* fix(skill): harden backport branch naming and PR body authoring Addresses issues seen in rel/0.34 backport PRs (#3133-#3135): - Branch slug now replaces every '/' in the target (rel/0.34 -> rel-0.34); PR #3133 produced backport/3036-to-rel/0.34 with the slash left in. - PR body must be passed via --body-file, never inline --body, which mangled descriptions and printed literal newline escape sequences verbatim. - Forbid task-list checkboxes in the PR body (GitHub renders them as a misleading 'N tasks done / Progress 100%' bar). - Do not hard-wrap body sentences; re-flow copied descriptions. - Clarify branch prefix: backport/ for local runs, copilot/ only for the GitHub.com cloud agent. * fix(skill): don't abort backport on gh auth status failure in cloud agent The Phase A 'abort if gh unauthenticated' gate caused the GitHub.com cloud agent to bail out of a backport before doing any git work when 'gh auth status' reported GITHUB_TOKEN invalid (see #3126). In the cloud agent, git push auth comes from the platform credential helper and the PR is opened by the platform - neither needs gh. Add a cloud-agent override so a failing 'gh auth status' no longer stops the backport; only PR-metadata edits need gh, with GH_TOKEN retry and REST API fallbacks. * fix(skill): address PR review on body-file portability and newline rationale - Make the body-file example cross-platform (TMPDIR/$env:TEMP) and keep it outside the repo so it can't be accidentally staged; add a cleanup note. - Correct the hard-wrap rationale: scope it to PR descriptions/comments (where GitHub honors single newlines as hard breaks, unlike rendered .md files) and add the noisy-diff / plaintext-preview reasons.

…tion

github-actions · 2026-06-10T13:43:28Z

🎉 Build Summary

🔗 Source

Commit: 9875993
Pull Request: #3126 removal of LLM instructions deployment logic

📦 Package Information

Version: 0.35.1
Preview: True
VSIX File: vscode-cosmosdb-0.35.1.vsix
VSIX Size: 3.33 MB
Artifact: dev-languy-remove-llminstructions-deploy-logic-0.35.1-9875993.zip

🧪 Test Results

Unit Tests: ✅ success
Integration Tests: ✅ success

✅ Build Status

All checks completed successfully!

…etry support

Copilot

Pull request overview

This PR removes the extension’s LLM instruction file deployment/removal surface area (commands + setting) and replaces it with a best-effort activation-time cleanup to delete previously deployed instruction files when they are unmodified, aligning with issue #3125 (remove LLM asset management setting from VS Code Settings).

Changes:

Removed the cosmosDB.manageLLMAssets contributed setting and the cosmosDB.ai.deployInstructionFiles / cosmosDB.ai.removeInstructionFiles commands.
Deleted the old deployment/removal implementation and its tests; added a new activation-time cleanup (cleanupLLMInstructionsFiles) that deletes the legacy instructions file only when its MD5 matches the known original and clears the obsolete manifest key.
Updated localization bundle entries and updated package-lock.json.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/extension.ts	Stops deploying instruction files on activation; adds activation-time cleanup call.
src/cosmosdb/commands/deployLLMInstructionsFiles.ts	Removes legacy deploy/remove logic (deleted).
src/cosmosdb/commands/deployLLMInstructionsFiles.test.ts	Removes tests for legacy deploy/remove logic (deleted).
src/cosmosdb/commands/cleanupLLMInstructionsFiles.ts	Adds new best-effort cleanup logic + telemetry.
src/commands/registerCommands.ts	Removes registration of LLM assets commands.
package.json	Removes LLM commands and the `cosmosDB.manageLLMAssets` configuration contribution.
package-lock.json	Updates lockfile (notably removes `libc` fields from multiple native/binary packages).
l10n/bundle.l10n.json	Removes now-unused localized strings for the deleted feature.
resources/llm-assets/.gitkeep	Keeps the (now-empty) llm-assets folder in the repo.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

mkrueger · 2026-06-11T14:57:56Z

Format checks fail for me all the time too :/ - how about using an auto formatter on checkin?

github-actions · 2026-06-11T15:17:19Z

🎭 E2E Tests (Playwright + VS Code)

Commit: a9df80c
Pull Request: #3126 removal of LLM instructions deployment logic

🧪 Result

E2E Tests: ✅ success

📥 Artifacts (run)

e2e-results-1 — 202 B
e2e-html-report-1 — 198.5 KB

Tip: the HTML report artifact contains a self-contained Playwright report.
Download the zip, extract, and open index.html — or run
npx playwright show-report <extracted-dir> for the interactive view.

github-actions · 2026-06-11T15:47:29Z

🔨 Build, Lint & Test

🔗 Source

Commit: a9df80c
Pull Request: #3126 removal of LLM instructions deployment logic

📦 Package Information

Version: 0.35.1
Preview: True
VSIX File: vscode-cosmosdb-0.35.1.vsix
VSIX Size: 3.34 MB
Artifact: dev-languy-remove-llminstructions-deploy-logic-0.35.1-a9df80c.zip

🧪 Test Results

Unit Tests: ✅ success
Integration Tests (extension host): ✅ success

📥 Artifacts (run)

dev-languy-remove-llminstructions-deploy-logic-0.35.1-a9df80c — 3.34 MB

✅ Build Status

Build and local tests passed. See sibling comments below for E2E and NoSQL integration results.

refactor: remove LLM instructions deployment logic and related assets

0e6d625

languy marked this pull request as ready for review June 5, 2026 08:19

languy requested a review from a team as a code owner June 5, 2026 08:19

bk201- previously approved these changes Jun 5, 2026

View reviewed changes

Copilot started work on behalf of sevoku June 8, 2026 20:09 View session

Copilot finished work on behalf of sevoku June 8, 2026 20:11

Copilot AI requested a review from sevoku June 8, 2026 20:11

Copilot started work on behalf of sevoku June 8, 2026 20:21 View session

Copilot AI changed the title ~~refactor: remove LLM instructions deployment logic and related assets~~ [rel/0.34] Backport removal of LLM instructions deployment logic Jun 8, 2026

Copilot finished work on behalf of sevoku June 8, 2026 20:25

sevoku previously approved these changes Jun 8, 2026

View reviewed changes

sevoku changed the title ~~[rel/0.34] Backport removal of LLM instructions deployment logic~~ removal of LLM instructions deployment logic Jun 8, 2026

feat: add cleanup logic for obsolete LLM instructions files on activa…

2f30787

…tion

languy dismissed stale reviews from sevoku and bk201- via 2f30787 June 10, 2026 13:39

refactor: enhance cleanup logic for LLM instructions files with telem…

9875993

…etry support

languy requested a review from Copilot June 11, 2026 06:17

Copilot started reviewing on behalf of languy June 11, 2026 06:17 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread src/cosmosdb/commands/cleanupLLMInstructionsFiles.ts

Comment thread src/cosmosdb/commands/cleanupLLMInstructionsFiles.ts Outdated

Comment thread src/cosmosdb/commands/cleanupLLMInstructionsFiles.ts Outdated

Comment thread l10n/bundle.l10n.json

bk201- previously approved these changes Jun 11, 2026

View reviewed changes

Potential fix for pull request finding

3a221f4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

languy dismissed bk201-’s stale review via 3a221f4 June 11, 2026 14:28

languy and others added 2 commits June 11, 2026 16:28

Potential fix for pull request finding

6eac021

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Potential fix for pull request finding

46ba0b8

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into dev/languy/remove-llminstructions-deploy-logic

201635c

Fix format

a9df80c

bk201- approved these changes Jun 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removal of LLM instructions deployment logic#3126

removal of LLM instructions deployment logic#3126
languy wants to merge 8 commits into
mainfrom
dev/languy/remove-llminstructions-deploy-logic

languy commented Jun 4, 2026 •

edited

Loading

Uh oh!

sevoku commented Jun 8, 2026

Uh oh!

Copilot AI commented Jun 8, 2026

Uh oh!

sevoku left a comment

Uh oh!

github-actions Bot commented Jun 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkrueger commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

languy commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sevoku commented Jun 8, 2026

Uh oh!

Copilot AI commented Jun 8, 2026

Uh oh!

sevoku left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎉 Build Summary

🔗 Source

📦 Package Information

🧪 Test Results

✅ Build Status

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mkrueger commented Jun 11, 2026

Uh oh!

github-actions Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎭 E2E Tests (Playwright + VS Code)

🧪 Result

📥 Artifacts (run)

Uh oh!

github-actions Bot commented Jun 11, 2026

🔨 Build, Lint & Test

🔗 Source

📦 Package Information

🧪 Test Results

📥 Artifacts (run)

✅ Build Status

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

languy commented Jun 4, 2026 •

edited

Loading

github-actions Bot commented Jun 10, 2026 •

edited

Loading

github-actions Bot commented Jun 11, 2026 •

edited

Loading