Update release comment handler for mentions#2610
Open
claudiaregio wants to merge 1 commit intomainfrom
Open
Conversation
… capping out at 50
Member
|
Overall this is a nice cleanup — merging the two steps removes the GITHUB_ENV fragility and One minor thing: the PR removes the early-exit guard for when there are zero participants, but the // prerelease (current) - no guard
message = `${mentions}\n\nA fix for this issue is now available...`;
// stable - has a guard ✅
message = mentions.trim() !== ""
? `${mentions}\n\nThis issue has been fixed!...`
: `This issue has been fixed!...`;Worth adding the same guard to the message = mentions.trim() !== ""
? `${mentions}\n\nA fix for this issue is now available...`
: `A fix for this issue is now available...`; |
emaf
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance release comment handler to more users to mention since it was capping out at 50