Skip to content

Align pipeline npm registry with .npmrc feed#475

Merged
edvilme merged 14 commits intomainfrom
fix/align-npm-registry-feed
Mar 17, 2026
Merged

Align pipeline npm registry with .npmrc feed#475
edvilme merged 14 commits intomainfrom
fix/align-npm-registry-feed

Conversation

@edvilme
Copy link
Contributor

@edvilme edvilme commented Mar 11, 2026

Add per-registry always-auth=false for the python-environments feed in .npmrc.

In CI, the pipeline template sets always-auth=true globally and writes an auth token for the Pylance_PublicPackages feed. During vsce package, npm tries to reach the @vscode:registry (python-environments feed) and sends the wrong auth token, causing E401. The always-auth=false override for that specific registry URL prevents this.

Pipeline AZURE_ARTIFACTS_FEED remains Pylance_PublicPackages (unchanged from main).

@edvilme edvilme added the debt Technical debt or repo cleanup label Mar 11, 2026
@edvilme edvilme enabled auto-merge (squash) March 11, 2026 18:07
@edvilme edvilme force-pushed the fix/align-npm-registry-feed branch from c5661bf to 7b19c42 Compare March 11, 2026 18:10
Update AZURE_ARTIFACTS_FEED to use the azure-public/python-environments
feed to match the .npmrc configuration, fixing E401 auth errors during
vsce package in CI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme edvilme force-pushed the fix/align-npm-registry-feed branch from 7b19c42 to f84523b Compare March 11, 2026 18:12
edvilme and others added 2 commits March 11, 2026 11:31
Keep .npmrc pointing to the public python-environments feed for local
dev. Only the pipeline YAML files should use msft_consumption.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align .npmrc with pipeline YAML files to use the same msft_consumption
feed for @VScode scoped packages.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@edvilme edvilme disabled auto-merge March 11, 2026 18:52
edvilme and others added 4 commits March 11, 2026 12:14
The msft_consumption feed requires auth in CI pipelines, causing E401
during npm ci. Keep .npmrc on the public python-environments feed
for both local dev and CI compatibility.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Switch @VScode scoped registry to msft_consumption feed and explicitly
disable auth for it, preventing E401 in CI where npmAuthenticate sets
always-auth=true for a different feed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Explicitly disable auth for the msft_consumption scoped registry to
prevent CI's npmAuthenticate from sending an invalid token to this
public feed, fixing E401 during vsce package.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revert AZURE_ARTIFACTS_FEED to Pylance_PublicPackages (same org as
pipeline, auth works). Keep .npmrc on public python-environments feed
but add per-registry always-auth=false to prevent CI's npmAuthenticate
from sending the wrong auth token during vsce package.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rchiodo
rchiodo previously approved these changes Mar 11, 2026
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

Update .npmrc to use msft_consumption feed for @VScode scoped packages
and remove trigger/PR sections from azure-pipeline.validation.yml.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rchiodo
rchiodo previously approved these changes Mar 13, 2026
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

Replace @VScode:registry in .npmrc with a direct tarball URL in
package.json for @vscode/python-environments from the msft_consumption
feed. This avoids scoped registry conflicts with other @VScode packages
in CI. Also update validation pipeline triggers to wildcard branches
with drafts enabled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rchiodo
rchiodo previously approved these changes Mar 16, 2026
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

edvilme and others added 2 commits March 17, 2026 10:54
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme and others added 2 commits March 17, 2026 12:08
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use MicroBuild.1ES.Unofficial.yml for PR/validation builds and add
sourceAnalysisPool, matching the isort repo configuration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

extends:
template: azure-pipelines/MicroBuild.1ES.Official.yml@MicroBuildTemplate
template: azure-pipelines/MicroBuild.1ES.Unofficial.yml@MicroBuildTemplate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched from MicroBuild.1ES.Official.yml to MicroBuild.1ES.Unofficial.yml and added sourceAnalysisPool to match the isort repo. The Official template was failing with a 1ES PT pool/os mismatch error. Unofficial is the correct template for PR/validation builds.

@edvilme edvilme enabled auto-merge (squash) March 17, 2026 19:30
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@edvilme edvilme merged commit 8d25a35 into main Mar 17, 2026
22 checks passed
@edvilme edvilme deleted the fix/align-npm-registry-feed branch March 17, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Technical debt or repo cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants