More VS Code Onboarding TPI Fixes#309673
Open
eli-w-king wants to merge 4 commits intorelease/1.116from
Open
Conversation
The theme preview SVGs were not bundled in desktop or web builds, causing blank theme cards for users running built products. Fixes #309380
After the user signs in through the onboarding walkthrough, trigger the full chat setup flow in the background (sign-up, extension install, entitlement resolution) so the 'Finish Setup' status bar indicator is resolved by the time onboarding completes. Uses disableChatViewReveal and DefaultSetup strategy to avoid showing dialogs or popping the chat panel during onboarding. Fixes #309529
Shows Cmd+Shift+X (Ctrl+Shift+X on Windows/Linux) in the extensions step subtitle so users know how to browse the full marketplace. Fixes #309617
eli-w-king
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multiple fixes for the onboarding walkthrough (cherry-picked #309654 to release/1.116):
1. Theme preview SVGs not showing in builds
Added
out-build/vs/workbench/contrib/welcomeOnboarding/browser/media/*.svgto desktop and web build file lists.2. "Finish Setup" indicator remains after onboarding sign-in
Triggers
workbench.action.chat.triggerSetupwithdisableChatViewReveal: trueandDefaultSetupstrategy after sign-in.3. Extension Marketplace keybinding tip
Added
Cmd+Shift+X/Ctrl+Shift+Xtip to the Extensions step subtitle.4. Screenreader accessibility
aria-labelon extension install buttons with extension namerole="group"andaria-labelFixes: #309380
Fixes: #309382
Fixes: #309521
Fixes: #309525
Fixes: #309529
Fixes: #309617