fix: resolve NoChangeError tool name interpolation and typo#309709
Open
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: resolve NoChangeError tool name interpolation and typo#309709Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Jah-yee wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Summary
Fixes two issues in the NoChangeError message:
Broken template interpolation: The original code uses single quotes for a string containing
${ToolName.ReadFile}, but JavaScript template literals require backticks for interpolation. The model literally receives the text${ToolName.ReadFile}instead ofread_file.Typo: Fixed duplicate "and" in "re-read the file and and determine" → "re-read the file and determine".
Changes
Changed:
Use the ${ToolName.ReadFile} tool to re-read the file and and determineTo:
Use the read_file tool to re-read the file and determineThis error message is shown when the replace_string_in_file tool produces no actual change. The garbled tool name prevented the model from following the recovery instruction to re-read the file.
Warmly, RoomWithOutRoof