Separate CTA widget from update title bar entry#309723
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR separates the post-update “What’s New” call-to-action (CTA) experience from the update title bar indicator, moving post-install content rendering into a standalone widget and introducing a parser for richer update-info payloads (markdown + custom buttons).
Changes:
- Added a new
parseUpdateInfoInpututility to parse update-info payloads (JSON envelope or frontmatter) including optional button definitions. - Removed post-install markdown rendering/version-change detection from the title bar update entry and tooltip.
- Introduced
PostUpdateWidgetContributionto show a sticky hover widget after update installs, plus styling and a richer developer prompt for testing.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/update/common/updateInfoParser.ts | New parsing utility for update info payloads supporting optional buttons. |
| src/vs/workbench/contrib/update/browser/updateTooltip.ts | Removes post-install markdown section/rendering from the tooltip. |
| src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts | Removes post-install/version-change logic so title bar entry focuses on update states only. |
| src/vs/workbench/contrib/update/browser/update.contribution.ts | Registers PostUpdateWidgetContribution and updates dev command prompt text. |
| src/vs/workbench/contrib/update/browser/postUpdateWidget.ts | New post-update widget shown via hover, fetching/parsing update info and rendering markdown/buttons. |
| src/vs/workbench/contrib/update/browser/media/postUpdateWidget.css | Styles for the new post-update widget hover content. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/update/browser/postUpdateWidget.ts:184
- The click listeners added via
dom.addDisposableListeneraren't registered/disposed. When combined with a sticky hover that can be shown repeatedly, this risks retaining closures (services, args) longer than necessary. Please register these disposables (eg via aDisposableStore) and dispose them when the hover is closed (for example via the hover target'sdispose).
dom.addDisposableListener(button, 'click', () => {
this.telemetryService.publicLog2<WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification>(
'workbenchActionExecuted',
{ id: commandId, from: 'postUpdateWidget' }
);
void this.commandService.executeCommand(commandId, ...(args ?? []));
this.hoverService.hideHover(true);
});
- Files reviewed: 7/7 changed files
- Comments generated: 4
Co-authored-by: Copilot <copilot@github.com>
chrmarti
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds upon #308064 by @cwebster-99 to separate CTA widget from update title bar control and enrich support format to allow specifying custom buttons.