Skip to content

Update the chat panel title when the mode changes#309726

Merged
mjbvz merged 2 commits intomicrosoft:mainfrom
mjbvz:dev/mjbvz/enormous-tyrannosaurus
Apr 14, 2026
Merged

Update the chat panel title when the mode changes#309726
mjbvz merged 2 commits intomicrosoft:mainfrom
mjbvz:dev/mjbvz/enormous-tyrannosaurus

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Apr 14, 2026

@mjbvz mjbvz self-assigned this Apr 14, 2026
Copilot AI review requested due to automatic review settings April 14, 2026 05:31
@mjbvz mjbvz enabled auto-merge April 14, 2026 05:31
Similar to microsoft#304274 but for chat editors too
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to keep chat UI titles in sync when the underlying chat “mode”/session backing the widget changes, by ensuring host components react to view model/session transitions and refresh their title sources accordingly.

Changes:

  • Update the chat view pane title control when the chat widget’s view model changes.
  • Allow ChatEditorInput to switch which IChatModel it tracks (and rewire change listeners) after initial creation.
  • Have the chat editor react to widget view model changes and update the associated ChatEditorInput to the new session model.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts Refreshes the view-pane title control when the widget swaps view models/sessions.
src/vs/workbench/contrib/chat/browser/widgetHosts/editor/chatEditorInput.ts Adds support for retargeting the editor input to a new chat model and tracking its label/icon changes.
src/vs/workbench/contrib/chat/browser/widgetHosts/editor/chatEditor.ts Listens for widget view model changes and updates the open editor input’s tracked model accordingly.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 1

@mjbvz mjbvz merged commit b400218 into microsoft:main Apr 14, 2026
25 of 26 checks passed
@vs-code-engineering vs-code-engineering bot added this to the 1.117.0 milestone Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copilot CLI/Claude agent lacks title bar until it gets re-opened

3 participants