Skip to content

Allow configuring the secondary side bar location #320701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlejandroRomeroG wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow configuring the secondary side bar location #320701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd0be2e
Support configurable secondary side bar location
AlejandroRomeroG Jun 9, 2026
37d7a86
Address secondary side bar location review feedback
AlejandroRomeroG Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 110 additions & 6 deletions src/vs/workbench/browser/actions/layoutActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { MenuId, MenuRegistry, registerAction2, Action2 } from '../../../platfor
import { Categories } from '../../../platform/action/common/actionCommonCategories.js';
import { IConfigurationService } from '../../../platform/configuration/common/configuration.js';
import { alert } from '../../../base/browser/ui/aria/aria.js';
import { EditorActionsLocation, EditorTabsMode, IWorkbenchLayoutService, LayoutSettings, Parts, Position, ZenModeSettings, positionToString } from '../../services/layout/browser/layoutService.js';
import { EditorActionsLocation, EditorTabsMode, IWorkbenchLayoutService, LayoutSettings, Parts, Position, SecondarySideBarLocation, ZenModeSettings, auxiliaryBarPositionFromConfiguration, positionToString } from '../../services/layout/browser/layoutService.js';
import { ServicesAccessor, IInstantiationService } from '../../../platform/instantiation/common/instantiation.js';
import { KeyMod, KeyCode } from '../../../base/common/keyCodes.js';
import { isWindows, isLinux, isWeb, isMacintosh, isNative } from '../../../base/common/platform.js';
Expand Down Expand Up @@ -96,6 +96,23 @@ registerAction2(class extends Action2 {

// --- Set Sidebar Position
const sidebarPositionConfigurationKey = 'workbench.sideBar.location';
const secondarySideBarPositionConfigurationKey = LayoutSettings.SECONDARY_SIDE_BAR_LOCATION;

const SecondarySideBarLeftContext = ContextKeyExpr.or(
ContextKeyExpr.equals(`config.${secondarySideBarPositionConfigurationKey}`, SecondarySideBarLocation.LEFT),
ContextKeyExpr.and(
ContextKeyExpr.equals(`config.${secondarySideBarPositionConfigurationKey}`, SecondarySideBarLocation.OPPOSITE),
ContextKeyExpr.equals(`config.${sidebarPositionConfigurationKey}`, 'right')
)
) ?? ContextKeyExpr.false();

const SecondarySideBarRightContext = ContextKeyExpr.or(
ContextKeyExpr.equals(`config.${secondarySideBarPositionConfigurationKey}`, SecondarySideBarLocation.RIGHT),
ContextKeyExpr.and(
ContextKeyExpr.equals(`config.${secondarySideBarPositionConfigurationKey}`, SecondarySideBarLocation.OPPOSITE),
ContextKeyExpr.equals(`config.${sidebarPositionConfigurationKey}`, 'left')
)
) ?? ContextKeyExpr.false();

class MoveSidebarPositionAction extends Action2 {
constructor(id: string, title: ICommandActionTitle, private readonly position: Position) {
Expand Down Expand Up @@ -136,6 +153,46 @@ class MoveSidebarLeftAction extends MoveSidebarPositionAction {
registerAction2(MoveSidebarRightAction);
registerAction2(MoveSidebarLeftAction);

class MoveSecondarySideBarPositionAction extends Action2 {
constructor(id: string, title: ICommandActionTitle, private readonly position: Position) {
super({
id,
title,
f1: false
});
}

async run(accessor: ServicesAccessor): Promise<void> {
const configurationService = accessor.get(IConfigurationService);

const configuredPosition = configurationService.getValue<SecondarySideBarLocation>(secondarySideBarPositionConfigurationKey);
const position = this.position === Position.LEFT ? SecondarySideBarLocation.LEFT : SecondarySideBarLocation.RIGHT;

if (configuredPosition !== position) {
return configurationService.updateValue(secondarySideBarPositionConfigurationKey, position);
}
}
Comment on lines +165 to +174
}

class MoveSecondarySideBarRightAction extends MoveSecondarySideBarPositionAction {
static readonly ID = 'workbench.action.moveSecondarySideBarRight';

constructor() {
super(MoveSecondarySideBarRightAction.ID, localize2('moveSecondarySideBarRight', "Move Secondary Side Bar Right"), Position.RIGHT);
}
}

class MoveSecondarySideBarLeftAction extends MoveSecondarySideBarPositionAction {
static readonly ID = 'workbench.action.moveSecondarySideBarLeft';

constructor() {
super(MoveSecondarySideBarLeftAction.ID, localize2('moveSecondarySideBarLeft', "Move Secondary Side Bar Left"), Position.LEFT);
}
}

registerAction2(MoveSecondarySideBarRightAction);
registerAction2(MoveSecondarySideBarLeftAction);

// --- Toggle Sidebar Position

export class ToggleSidebarPositionAction extends Action2 {
Expand Down Expand Up @@ -170,6 +227,46 @@ export class ToggleSidebarPositionAction extends Action2 {

registerAction2(ToggleSidebarPositionAction);

export class ToggleSecondarySideBarPositionAction extends Action2 {

static readonly ID = 'workbench.action.toggleSecondarySideBarPosition';
static readonly LABEL = localize('toggleSecondarySideBarPosition', "Toggle Secondary Side Bar Position");

static getLabel(layoutService: IWorkbenchLayoutService, configurationService: IConfigurationService): string {
const position = auxiliaryBarPositionFromConfiguration(
layoutService.getSideBarPosition(),
configurationService.getValue<SecondarySideBarLocation>(secondarySideBarPositionConfigurationKey)
);

return position === Position.LEFT ? localize('moveSecondarySideBarRight', "Move Secondary Side Bar Right") : localize('moveSecondarySideBarLeft', "Move Secondary Side Bar Left");
}

constructor() {
super({
id: ToggleSecondarySideBarPositionAction.ID,
title: localize2('toggleSecondarySideBarPosition', "Toggle Secondary Side Bar Position"),
category: Categories.View,
f1: true,
precondition: IsSessionsWindowContext.negate()
});
}

run(accessor: ServicesAccessor): Promise<void> {
const layoutService = accessor.get(IWorkbenchLayoutService);
const configurationService = accessor.get(IConfigurationService);

const position = auxiliaryBarPositionFromConfiguration(
layoutService.getSideBarPosition(),
configurationService.getValue<SecondarySideBarLocation>(secondarySideBarPositionConfigurationKey)
);
const newPositionValue = (position === Position.LEFT) ? SecondarySideBarLocation.RIGHT : SecondarySideBarLocation.LEFT;

return configurationService.updateValue(secondarySideBarPositionConfigurationKey, newPositionValue);
}
}

registerAction2(ToggleSecondarySideBarPositionAction);

const configureLayoutIcon = registerIcon('configure-layout-icon', Codicon.layout, localize('cofigureLayoutIcon', 'Icon represents workbench layout configuration.'));
MenuRegistry.appendMenuItem(MenuId.LayoutControlMenu, {
submenu: MenuId.LayoutControlMenuSubmenu,
Expand Down Expand Up @@ -210,21 +307,21 @@ MenuRegistry.appendMenuItems([{
item: {
group: '3_workbench_layout_move',
command: {
id: ToggleSidebarPositionAction.ID,
id: MoveSecondarySideBarLeftAction.ID,
title: localize('move second sidebar left', "Move Secondary Side Bar Left")
},
when: ContextKeyExpr.and(ContextKeyExpr.notEquals('config.workbench.sideBar.location', 'right'), ContextKeyExpr.equals('viewContainerLocation', ViewContainerLocationToString(ViewContainerLocation.AuxiliaryBar))),
when: ContextKeyExpr.and(SecondarySideBarRightContext, ContextKeyExpr.equals('viewContainerLocation', ViewContainerLocationToString(ViewContainerLocation.AuxiliaryBar))),
order: 1
}
}, {
id: MenuId.ViewContainerTitleContext,
item: {
group: '3_workbench_layout_move',
command: {
id: ToggleSidebarPositionAction.ID,
id: MoveSecondarySideBarRightAction.ID,
title: localize('move second sidebar right', "Move Secondary Side Bar Right")
},
when: ContextKeyExpr.and(ContextKeyExpr.equals('config.workbench.sideBar.location', 'right'), ContextKeyExpr.equals('viewContainerLocation', ViewContainerLocationToString(ViewContainerLocation.AuxiliaryBar))),
when: ContextKeyExpr.and(SecondarySideBarLeftContext, ContextKeyExpr.equals('viewContainerLocation', ViewContainerLocationToString(ViewContainerLocation.AuxiliaryBar))),
order: 1
}
}]);
Expand Down Expand Up @@ -1365,7 +1462,7 @@ if (!isMacintosh || !isNative) {
ToggleVisibilityActions.push(...[
CreateToggleLayoutItem(ToggleActivityBarVisibilityActionId, ContextKeyExpr.notEquals('config.workbench.activityBar.location', 'hidden'), localize('activityBar', "Activity Bar"), { whenA: ContextKeyExpr.equals('config.workbench.sideBar.location', 'left'), iconA: activityBarLeftIcon, iconB: activityBarRightIcon }),
CreateToggleLayoutItem(ToggleSidebarVisibilityAction.ID, SideBarVisibleContext, localize('sideBar', "Primary Side Bar"), { whenA: ContextKeyExpr.equals('config.workbench.sideBar.location', 'left'), iconA: panelLeftIcon, iconB: panelRightIcon }),
CreateToggleLayoutItem(ToggleAuxiliaryBarAction.ID, AuxiliaryBarVisibleContext, localize('secondarySideBar', "Secondary Side Bar"), { whenA: ContextKeyExpr.equals('config.workbench.sideBar.location', 'left'), iconA: panelRightIcon, iconB: panelLeftIcon }),
CreateToggleLayoutItem(ToggleAuxiliaryBarAction.ID, AuxiliaryBarVisibleContext, localize('secondarySideBar', "Secondary Side Bar"), { whenA: SecondarySideBarRightContext, iconA: panelRightIcon, iconB: panelLeftIcon }),
CreateToggleLayoutItem(TogglePanelAction.ID, PanelVisibleContext, localize('panel', "Panel"), panelIcon),
CreateToggleLayoutItem(ToggleStatusbarVisibilityAction.ID, ContextKeyExpr.equals('config.workbench.statusBar.visible', true), localize('statusBar', "Status Bar"), statusBarIcon),
]);
Expand Down Expand Up @@ -1399,6 +1496,13 @@ for (const { active } of [...ToggleVisibilityActions, ...MoveSideBarActions, ...
LayoutContextKeySet.add(key);
}
}
for (const { visualIcon } of [...ToggleVisibilityActions, ...MoveSideBarActions, ...AlignPanelActions, ...QuickInputActions, ...MiscLayoutOptions]) {
if (visualIcon && isContextualLayoutVisualIcon(visualIcon)) {
for (const key of visualIcon.whenA.keys()) {
LayoutContextKeySet.add(key);
}
}
}

/**
* Matches the title bar's `editorActionsEnabled` getter: true when editor
Expand Down
Loading