Prevent clipped suggest widget list items#327378
Open
hawkticehurst with Copilot wants to merge 2 commits into
Open
Prevent clipped suggest widget list items#327378hawkticehurst with Copilot wants to merge 2 commits into
hawkticehurst with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
hawkticehurst
July 24, 2026 20:22
View session
hawkticehurst
marked this pull request as ready for review
July 24, 2026 20:36
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents Modern UI suggest-widget focus rows from appearing clipped by rounded overlay edges.
Changes:
- Adds a Modern UI-scoped radius override for suggest rows.
- Excludes separator rows.
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/styleOverrides/browser/media/roundedCorners.css:224
- This introduces another
!importantoverride. It is needed only because the broad list-row declaration at lines 62-64 is itself important; please narrow or restructure that rule so the suggest-specific declaration wins by selector ownership/specificity instead of adding a second important declaration.
border-radius: var(--vscode-cornerRadius-large) !important;
Comment on lines
+223
to
+224
| .style-override .editor-widget.suggest-widget .monaco-list .monaco-list-row:not(.separator) { | ||
| border-radius: var(--vscode-cornerRadius-large) !important; |
Contributor
Author
There was a problem hiding this comment.
Fixed in the latest commit. The rule now only applies cornerRadius-large to the first and last rows (boundary rows), following the notificationsCenter.css pattern. Interior rows keep the Control radius (cornerRadius-small) from the generic list-row rule.
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern UI clipped focused rows at the suggest widget’s rounded edges.