chat: preserve Agent Host sessions across Remote-SSH reloads#327425
Open
NathanielMcVicar wants to merge 2 commits into
Open
chat: preserve Agent Host sessions across Remote-SSH reloads#327425NathanielMcVicar wants to merge 2 commits into
NathanielMcVicar wants to merge 2 commits into
Conversation
Signed-off-by: Nathaniel McVicar <Nathaniel.McVicar@microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Remote-SSH Agent Host sessions being incorrectly filtered after reload by comparing their unwrapped working-directory URIs.
Changes:
- Unwrap Agent Host working-directory URIs before workspace matching.
- Add a Remote-SSH regression test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
agentHostSessionListStore.ts |
Unwraps working-directory URIs before filtering. |
agentHostChatContribution.test.ts |
Verifies remote sessions remain listed after refresh. |
Author
|
@TylerLeonhardt please take a look, I guess I don't have permission to assign PRs directly. Thanks! |
Signed-off-by: Nathaniel McVicar <Nathaniel.McVicar@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326630
Agent Host working directories can use wrapped file URIs under Remote SSH. These were erroneously filtered against the
vscode-remoteworkspace after a reload. Normalize all of these URIs to the local workspace before filtering and add a simple regression test.