voice: add first-use configuration banner#327426
Open
meganrogge wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-use Voice Mode onboarding, centralized disabling, and packaged voice-preview audio.
Changes:
- Adds an accessible configuration banner with preview, disable, and dismiss actions.
- Centralizes Voice Mode disabling through a shared command.
- Packages preview audio across desktop, server-web, and web builds.
Show a summary per file
| File | Description |
|---|---|
voiceInputModeActionViewItem.ts |
Uses centralized context-menu actions. |
voiceModeActionViewItem.ts |
Removes direct configuration dependency. |
micButtonMenuActions.ts |
Routes disabling through the shared command. |
agentsVoice.ts |
Defines shared command identifiers. |
agentsVoiceWindowService.ts |
Updates floating-window context-menu integration. |
agentsVoice.contribution.ts |
Implements banner, preview, and disable commands. |
build/next/index.ts |
Packages audio in esbuild targets. |
build/gulpfile.vscode.web.ts |
Packages audio in web builds. |
build/gulpfile.vscode.ts |
Packages audio in desktop builds. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Medium
| type VoicePreview = keyof typeof voicePreviewFiles; | ||
|
|
||
| function isVoicePreview(voice: string): voice is VoicePreview { | ||
| return voice in voicePreviewFiles; |
Comment on lines
+148
to
+151
| const shouldShow = this.configurationService.getValue<boolean>('agents.voice.enabled') === true | ||
| && !this.storageService.getBoolean(AgentsVoiceStorageKeys.OnboardingCompleted, StorageScope.PROFILE, false) | ||
| && !sentiment.hidden | ||
| && !sentiment.disabled; |
roblourens
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run typecheck-clientnpm run precommitnpm run valid-layers-checkgit diff --checkFixes #327203