agentHost: persist server-side session config changes#327450
Draft
roblourens wants to merge 3 commits into
Draft
agentHost: persist server-side session config changes#327450roblourens wants to merge 3 commits into
roblourens wants to merge 3 commits into
Conversation
Persist merged session config values for both client- and server-dispatched actions so mode changes survive session restore.\n\nFixes #327435.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR ensures Agent Host session config updates originating from the server are persisted so they survive session restore, and adds a regression test for this behavior.
Changes:
- Persist
SessionConfigChangedmerged config values when actions are server-dispatched (via envelope observation). - Keep plan acceptance/config mode changes across session restore by persisting merged
config.values. - Add a regression test covering server-originated
SessionConfigChangedpersistence.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/agentSideEffects.ts | Moves config persistence to an envelope observer so server-dispatched actions also persist merged config.values. |
| src/vs/platform/agentHost/test/node/agentSideEffects.test.ts | Adds a regression test asserting server-dispatched SessionConfigChanged persists merged config values. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Low
Keep fire-and-forget metadata persistence from surfacing synchronous database-open failures.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Poll for persisted metadata with a bounded timeout instead of relying on fixed delays.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionConfigChangedactionsValidation
npm run compile./scripts/test.sh --run src/vs/platform/agentHost/test/node/agentSideEffects.test.ts --grep "SessionConfigChanged persists merged config values"npm run precommitFixes #327435.
(Written by Copilot)