sessions: keep voice mode active in new session composer - #327637
Draft
meganrogge wants to merge 2 commits into
Draft
sessions: keep voice mode active in new session composer#327637meganrogge wants to merge 2 commits into
meganrogge wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Keeps connected Voice Mode routed to the Agents window’s active draft composer instead of a stale chat widget.
Changes:
- Routes draft composers through the existing voice sentinel.
- Adds regression coverage for session-to-draft and composer-unmount transitions.
Show a summary per file
| File | Description |
|---|---|
voiceBridge.contribution.ts |
Routes active draft composers to the voice sentinel. |
voiceBridge.contribution.test.ts |
Tests created-session, draft-composer, and unmounted-composer routing. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #327291
Validation
npm run typecheck-clientnpm run valid-layers-check./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/voiceBridge.contribution.test.tsnpm run precommit