chat: refine voice mode visual feedback - #327638
Draft
meganrogge wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refines voice-mode feedback to be calmer while preserving clear live-state cues.
Changes:
- Keeps instructional hints static while partial transcripts pulse.
- Reduces glow and waveform intensity.
- Compacts the segmented voice control and updates documentation/tests.
Show a summary per file
| File | Description |
|---|---|
voiceGlow.test.ts |
Updates the glow baseline. |
chatViewPane.css |
Separates static hints from animated transcripts. |
chatViewPane.ts |
Assigns the static hint class. |
chat.css |
Subdues toolbar icon glows. |
voiceInputModeActionViewItem.ts |
Reduces waveform amplitude. |
voiceInputMode.css |
Compacts the segmented control. |
voiceGlow.ts |
Reduces shared glow intensity. |
agentsVoiceWidget.ts |
Subdues standalone voice glows. |
LAYOUT.md |
Documents voice-mode presentation. |
voiceInputDecorations.ts |
Makes Agents hints static. |
voiceChatView.css |
Updates Agents transcript and icon styling. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 2
- Review effort level: Medium
|
|
||
| .chat-voice-input-mode-icon { | ||
| font-size: 16px; | ||
| font-size: var(--vscode-codiconFontSize-compact); |
Comment on lines
+57
to
+60
| const emphasized = voiceState === 'listening' && transcriptHidden; | ||
| const borderAlpha = (emphasized ? 0.35 : 0.3) + intensity * (emphasized ? 0.25 : 0.2); | ||
| const shadowSpread = (emphasized ? 3 : 2) + intensity * (emphasized ? 6 : 4); | ||
| const shadowAlpha = (emphasized ? 0.08 : 0.06) + intensity * (emphasized ? 0.14 : 0.12); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Addresses the team feedback in #327202 by making voice mode calmer at rest and less visually dominant while retaining clear state feedback and accessible controls.
Validation
npm run typecheck-clientnpm run compile-clientscripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/voiceClient/voiceGlow.test.tsnpm run valid-layers-checknpm run hygienegit diff --checkFixes #327202