Skip to content

feat: add --inf2cat-args passthrough to customize inf2cat options#702

Draft
svasista-ms wants to merge 3 commits into
microsoft:mainfrom
svasista-ms:feature/inf2cat-os-versions
Draft

feat: add --inf2cat-args passthrough to customize inf2cat options#702
svasista-ms wants to merge 3 commits into
microsoft:mainfrom
svasista-ms:feature/inf2cat-os-versions

Conversation

@svasista-ms

Copy link
Copy Markdown
Contributor

TBD

Copilot AI review requested due to automatic review settings July 13, 2026 04:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new cargo wdk build CLI option (--inf2cat-args) to forward user-supplied arguments to inf2cat during catalog generation, threading those arguments through the build/package action pipeline and documenting the behavior.

Changes:

  • Added --inf2cat-args to the build CLI, including parsing/tokenization logic and unit tests.
  • Plumbed inf2cat_args through BuildActionParamsPackageTaskParams and updated inf2cat invocation to either use defaults or forward caller-provided switches.
  • Updated build/package tests and the cargo-wdk README to mention the new option.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
crates/cargo-wdk/src/cli.rs Adds --inf2cat-args, tokenization parser, and CLI plumbing into BuildActionParams; adds unit tests.
crates/cargo-wdk/src/actions/build/mod.rs Adds inf2cat_args to build action params/state and forwards into packaging.
crates/cargo-wdk/src/actions/build/package_task.rs Stores forwarded inf2cat_args and changes inf2cat argument construction behavior; adds tests.
crates/cargo-wdk/src/actions/build/tests.rs Updates build action test initialization for the new parameter.
crates/cargo-wdk/README.md Documents the new CLI flag and describes inf2cat customization.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread crates/cargo-wdk/src/cli.rs Outdated
Comment thread crates/cargo-wdk/src/cli.rs Outdated
Comment thread crates/cargo-wdk/src/cli.rs Outdated
Comment thread crates/cargo-wdk/src/cli.rs Outdated
Comment thread crates/cargo-wdk/README.md Outdated
Comment thread crates/cargo-wdk/README.md Outdated
@codecov-commenter

codecov-commenter commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.61%. Comparing base (21ec8f8) to head (bbba2f6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
+ Coverage   79.93%   80.61%   +0.67%     
==========================================
  Files          26       26              
  Lines        5633     5830     +197     
  Branches     5633     5830     +197     
==========================================
+ Hits         4503     4700     +197     
  Misses       1002     1002              
  Partials      128      128              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings July 14, 2026 04:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs
Comment thread crates/cargo-wdk/README.md Outdated
Comment thread crates/cargo-wdk/src/cli.rs
docs: use better example for `inf2cat-args` usage
Copilot AI review requested due to automatic review settings July 14, 2026 12:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants